<p><a href="https://review.coreboot.org/25162">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25162/1/src/mainboard/google/poppy/variants/nami/devicetree.cb">File src/mainboard/google/poppy/variants/nami/devicetree.cb:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25162/1/src/mainboard/google/poppy/variants/nami/devicetree.cb@281">Patch Set #1, Line 281:</a> <code style="font-family:monospace,monospace">                             register "generic.disable_gpio_export_in_crs" = "1"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">register "generic.wake" = "GPE0_DW2_01"</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25162/1/src/mainboard/google/poppy/variants/nami/gpio.c">File src/mainboard/google/poppy/variants/nami/gpio.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25162/1/src/mainboard/google/poppy/variants/nami/gpio.c@215">Patch Set #1, Line 215:</a> <code style="font-family:monospace,monospace">PAD_CFG_GPI_GPIO_DRIVER</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should be ACPI_SCI</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25162/1/src/mainboard/google/poppy/variants/nami/gpio.c@229">Patch Set #1, Line 229:</a> <code style="font-family:monospace,monospace">ACPI_SCI</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">and this should be GPIO_DRIVER</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/25162">change 25162</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25162"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I5d87d938ac3a4e52e676850b9d8b80e83726275d </div>
<div style="display:none"> Gerrit-Change-Number: 25162 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Shelley Chen <shchen@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 15 Mar 2018 00:30:44 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>