[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nami: Use internal pulldown for MEM_CONFIG_4

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/25103


Change subject: mb/google/poppy/variants/nami: Use internal pulldown for MEM_CONFIG_4
......................................................................

mb/google/poppy/variants/nami: Use internal pulldown for MEM_CONFIG_4

Since nami proto did not have any external pull on MEM_CONFIG_4, use a
weak internal pull down before reading it.

BUG=b:74420123
TEST=Verified that the value read for MEM_CONFIG_4 is correct on nami.

Change-Id: I45989d2ca35b863f391baba9e2f2e602033217d4
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M src/mainboard/google/poppy/variants/nami/memory.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/25103/1

diff --git a/src/mainboard/google/poppy/variants/nami/memory.c b/src/mainboard/google/poppy/variants/nami/memory.c
index 6aa0e76..082b9a4 100644
--- a/src/mainboard/google/poppy/variants/nami/memory.c
+++ b/src/mainboard/google/poppy/variants/nami/memory.c
@@ -82,7 +82,7 @@
 void variant_memory_params(struct memory_params *p)
 {
 	memset(p, 0, sizeof(*p));
-	gpio_input(GPIO_MEM_CONFIG_4);
+	gpio_input_pulldown(GPIO_MEM_CONFIG_4);
 	if (gpio_get(GPIO_MEM_CONFIG_4))
 		/* set to LPDDR3 */
 		fill_lpddr3_memory_params(p);

-- 
To view, visit https://review.coreboot.org/25103
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I45989d2ca35b863f391baba9e2f2e602033217d4
Gerrit-Change-Number: 25103
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180312/2b013bc9/attachment.html>