<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25103">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/nami: Use internal pulldown for MEM_CONFIG_4<br><br>Since nami proto did not have any external pull on MEM_CONFIG_4, use a<br>weak internal pull down before reading it.<br><br>BUG=b:74420123<br>TEST=Verified that the value read for MEM_CONFIG_4 is correct on nami.<br><br>Change-Id: I45989d2ca35b863f391baba9e2f2e602033217d4<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/mainboard/google/poppy/variants/nami/memory.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/25103/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nami/memory.c b/src/mainboard/google/poppy/variants/nami/memory.c</span><br><span>index 6aa0e76..082b9a4 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nami/memory.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/nami/memory.c</span><br><span>@@ -82,7 +82,7 @@</span><br><span> void variant_memory_params(struct memory_params *p)</span><br><span> {</span><br><span>     memset(p, 0, sizeof(*p));</span><br><span style="color: hsl(0, 100%, 40%);">-       gpio_input(GPIO_MEM_CONFIG_4);</span><br><span style="color: hsl(120, 100%, 40%);">+        gpio_input_pulldown(GPIO_MEM_CONFIG_4);</span><br><span>      if (gpio_get(GPIO_MEM_CONFIG_4))</span><br><span>             /* set to LPDDR3 */</span><br><span>          fill_lpddr3_memory_params(p);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25103">change 25103</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25103"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I45989d2ca35b863f391baba9e2f2e602033217d4 </div>
<div style="display:none"> Gerrit-Change-Number: 25103 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>