[coreboot-gerrit] Change in coreboot[master]: coreboot_table: Print GPIO state correctly for lb_gpios

[Julius Werner (Code Review)]

Hello Nick Vaccaro, Furquan Shaikh,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/25022

to review the following change.


Change subject: coreboot_table: Print GPIO state correctly for lb_gpios
......................................................................

coreboot_table: Print GPIO state correctly for lb_gpios

Looks like there's a typo in the GPIO state table we print as part of
assembling the coreboot tables. Of course, high GPIOs are represented as
1 and low GPIOs as 0. Fix this display bug.

Change-Id: I59b4d49955c13f920576dd09f463e2d399ab64e0
Signed-off-by: Julius Werner <jwerner at chromium.org>
---
M src/lib/coreboot_table.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/25022/1

diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c
index aeaff28..d03b771 100644
--- a/src/lib/coreboot_table.c
+++ b/src/lib/coreboot_table.c
@@ -186,10 +186,10 @@
 			printk(BIOS_INFO, "     low | ");
 		switch (g->value) {
 		case 0:
-			printk(BIOS_INFO, "     high\n");
+			printk(BIOS_INFO, "      low\n");
 			break;
 		case 1:
-			printk(BIOS_INFO, "      low\n");
+			printk(BIOS_INFO, "     high\n");
 			break;
 		default:
 			printk(BIOS_INFO, "undefined\n");

-- 
To view, visit https://review.coreboot.org/25022
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I59b4d49955c13f920576dd09f463e2d399ab64e0
Gerrit-Change-Number: 25022
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180307/51fadcb6/attachment-0001.html>