<p>Julius Werner would like Nick Vaccaro and Furquan Shaikh to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/25022">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">coreboot_table: Print GPIO state correctly for lb_gpios<br><br>Looks like there's a typo in the GPIO state table we print as part of<br>assembling the coreboot tables. Of course, high GPIOs are represented as<br>1 and low GPIOs as 0. Fix this display bug.<br><br>Change-Id: I59b4d49955c13f920576dd09f463e2d399ab64e0<br>Signed-off-by: Julius Werner <jwerner@chromium.org><br>---<br>M src/lib/coreboot_table.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/25022/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c</span><br><span>index aeaff28..d03b771 100644</span><br><span>--- a/src/lib/coreboot_table.c</span><br><span>+++ b/src/lib/coreboot_table.c</span><br><span>@@ -186,10 +186,10 @@</span><br><span>                     printk(BIOS_INFO, "     low | ");</span><br><span>          switch (g->value) {</span><br><span>               case 0:</span><br><span style="color: hsl(0, 100%, 40%);">-                 printk(BIOS_INFO, "     high\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                   printk(BIOS_INFO, "      low\n");</span><br><span>                  break;</span><br><span>               case 1:</span><br><span style="color: hsl(0, 100%, 40%);">-                 printk(BIOS_INFO, "      low\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                   printk(BIOS_INFO, "     high\n");</span><br><span>                  break;</span><br><span>               default:</span><br><span>                     printk(BIOS_INFO, "undefined\n");</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25022">change 25022</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25022"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I59b4d49955c13f920576dd09f463e2d399ab64e0 </div>
<div style="display:none"> Gerrit-Change-Number: 25022 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Julius Werner <jwerner@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nick Vaccaro <nvaccaro@chromium.org> </div>