[coreboot-gerrit] Change in coreboot[master]: src/soc/amd/stoneyridge: clean up OSCOUT1_ClkOutputEnb

[Garrett Kirkendall (Code Review)]

Garrett Kirkendall has uploaded this change for review. ( https://review.coreboot.org/25009


Change subject: src/soc/amd/stoneyridge: clean up OSCOUT1_ClkOutputEnb
......................................................................

src/soc/amd/stoneyridge: clean up OSCOUT1_ClkOutputEnb

Change OSCOUT1_ClkOutputEnb programming to use registers from iomap.h
and southbridge.h

BUG=b:69220826
BRANCH=master
TEST=abuild, build Gardenia, build and boot Grunt

Change-Id: Ib138dae6057394740c415e882e4dbd925882c2de
Signed-off-by: Garrett Kirkendall <garrett.kirkendall at amd.corp-partner.google.com>
---
M src/soc/amd/stoneyridge/include/soc/southbridge.h
M src/soc/amd/stoneyridge/southbridge.c
2 files changed, 7 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/25009/1

diff --git a/src/soc/amd/stoneyridge/include/soc/southbridge.h b/src/soc/amd/stoneyridge/include/soc/southbridge.h
index 7eba4d6..599fa68 100644
--- a/src/soc/amd/stoneyridge/include/soc/southbridge.h
+++ b/src/soc/amd/stoneyridge/include/soc/southbridge.h
@@ -247,7 +247,8 @@
 #define SPI100_HOST_PREF_CONFIG		0x2c
 #define   SPI_RD4DW_EN_HOST		BIT(15)
 
-#define FCH_MISC_REG40_OSCOUT1_EN	BIT(2)
+#define MISC_MISC_CLK_CNTL_1		0x40
+#define   OSCOUT1_CLK_OUTPUT_ENB	BIT(2)  // 0 = Enabled, 1 = Disabled
 
 /* IO 0xcf9 - Reset control port*/
 #define   FULL_RST			BIT(3)
diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c
index 3d0cc74..c1dd516 100644
--- a/src/soc/amd/stoneyridge/southbridge.c
+++ b/src/soc/amd/stoneyridge/southbridge.c
@@ -365,11 +365,13 @@
 	 * Enable the X14M_25M_48M_OSC pin and leaving it at it's default so
 	 * 48Mhz will be on ball AP13 (FT3b package)
 	 */
-	ctrl = read32((void *)(ACPI_MMIO_BASE + MISC_BASE + FCH_MISC_REG40));
+	ctrl = read32((u32 *)(uintptr_t)(MISC_MMIO_BASE
+				+ MISC_MISC_CLK_CNTL_1));
 
 	/* clear the OSCOUT1_ClkOutputEnb to enable the 48 Mhz clock */
-	ctrl &= ~FCH_MISC_REG40_OSCOUT1_EN;
-	write32((void *)(ACPI_MMIO_BASE + MISC_BASE + FCH_MISC_REG40), ctrl);
+	ctrl &= ~OSCOUT1_CLK_OUTPUT_ENB;
+	write32((u32 *)(uintptr_t)(MISC_MMIO_BASE
+				+ MISC_MISC_CLK_CNTL_1), ctrl);
 }
 
 static uintptr_t sb_spibase(void)

-- 
To view, visit https://review.coreboot.org/25009
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib138dae6057394740c415e882e4dbd925882c2de
Gerrit-Change-Number: 25009
Gerrit-PatchSet: 1
Gerrit-Owner: Garrett Kirkendall <garrett.kirkendall at amd.corp-partner.google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180306/7f8ade4c/attachment.html>