[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy : Get SKU_ID from EC for Nami/Vayne

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/24996 )

Change subject: mb/google/poppy : Get SKU_ID from EC for Nami/Vayne
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/24996/1/src/mainboard/google/poppy/ramstage.c
File src/mainboard/google/poppy/ramstage.c:

https://review.coreboot.org/#/c/24996/1/src/mainboard/google/poppy/ramstage.c@28
PS1, Line 28: board_sku_id
This should be moved under mainboard/google/poppy/variants/nami/.


https://review.coreboot.org/#/c/24996/1/src/mainboard/google/poppy/ramstage.c@48
PS1, Line 48: mainboard_devtree_update
Do you intend to do this before FSP-S is run? 

If yes, then you can add a call in mainboard_silicon_init_params to do variant_silicon_init_params(FSP_SIL_UPD *params) and handle enabling/disabling of ports there.

If no, then you can keep the ports enabled in devicetree.cb for nami and handle it in something like mainboard/google/poppy/variants/nami/pl2.c. Though, you will have to rename pl2.c to something like device.c.


https://review.coreboot.org/#/c/24996/1/src/soc/intel/skylake/chip_fsp20.c
File src/soc/intel/skylake/chip_fsp20.c:

https://review.coreboot.org/#/c/24996/1/src/soc/intel/skylake/chip_fsp20.c@105
PS1, Line 105: mainboard_devtree_update
There is no need to add a callback from SoC code. This can be handled completely in mainboard/variant-specific code.



-- 
To view, visit https://review.coreboot.org/24996
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I42dd177de8c49cf3c122c2ebb1fcf42e5ba4cd75
Gerrit-Change-Number: 24996
Gerrit-PatchSet: 1
Gerrit-Owner: Amanda Hwang <amanda_hwang at compal.corp-partner.google.com>
Gerrit-Reviewer: Daisuke Nojiri <dnojiri at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Jimmy M Wang <jimmym_wang at compal.corp-partner.google.com>
Gerrit-Reviewer: Van Chen <van_chen at compal.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 05 Mar 2018 15:00:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180305/652301bd/attachment.html>