[coreboot-gerrit] Change in coreboot[master]: ec/chromeec: Fix check for UHEPI support

[Matt DeVillier (Code Review)]

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/24982


Change subject: ec/chromeec: Fix check for UHEPI support
......................................................................

ec/chromeec: Fix check for UHEPI support

Commit 1dfc2c3
[google/chromeec: Enable unified host event programming interface]
added support for UHEPI, but google_chromeec_is_uhepi_supported()
incorrect treats negative error return codes from
google_chromeec_check_feature() as supported. Fix this check to only
treat positive return values as supported, as per the original intent.

Test: boot google/lulu, verify cbmem console reports UHEPI not
supported even if feature check returns error code, verify lid/kb
wake events correct wake the device from S3/sleep.

Change-Id: I7846efb340bc1546b074e8502daf906c444bd146
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/ec/google/chromeec/ec.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/24982/1

diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c
index ef7a217..28625e4 100644
--- a/src/ec/google/chromeec/ec.c
+++ b/src/ec/google/chromeec/ec.c
@@ -224,7 +224,7 @@
 
 	if (!uhepi_support) {
 		uhepi_support = google_chromeec_check_feature
-			(EC_FEATURE_UNIFIED_WAKE_MASKS) ? UHEPI_SUPPORTED :
+			(EC_FEATURE_UNIFIED_WAKE_MASKS) > 0 ? UHEPI_SUPPORTED :
 			UHEPI_NOT_SUPPORTED;
 		printk(BIOS_DEBUG, "Chrome EC: UHEPI %s\n",
 			uhepi_support == UHEPI_SUPPORTED ?

-- 
To view, visit https://review.coreboot.org/24982
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7846efb340bc1546b074e8502daf906c444bd146
Gerrit-Change-Number: 24982
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180304/1a5f70a9/attachment.html>