<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/24982">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ec/chromeec: Fix check for UHEPI support<br><br>Commit 1dfc2c3<br>[google/chromeec: Enable unified host event programming interface]<br>added support for UHEPI, but google_chromeec_is_uhepi_supported()<br>incorrect treats negative error return codes from<br>google_chromeec_check_feature() as supported. Fix this check to only<br>treat positive return values as supported, as per the original intent.<br><br>Test: boot google/lulu, verify cbmem console reports UHEPI not<br>supported even if feature check returns error code, verify lid/kb<br>wake events correct wake the device from S3/sleep.<br><br>Change-Id: I7846efb340bc1546b074e8502daf906c444bd146<br>Signed-off-by: Matt DeVillier <matt.devillier@gmail.com><br>---<br>M src/ec/google/chromeec/ec.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/24982/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c</span><br><span>index ef7a217..28625e4 100644</span><br><span>--- a/src/ec/google/chromeec/ec.c</span><br><span>+++ b/src/ec/google/chromeec/ec.c</span><br><span>@@ -224,7 +224,7 @@</span><br><span> </span><br><span>     if (!uhepi_support) {</span><br><span>                uhepi_support = google_chromeec_check_feature</span><br><span style="color: hsl(0, 100%, 40%);">-                   (EC_FEATURE_UNIFIED_WAKE_MASKS) ? UHEPI_SUPPORTED :</span><br><span style="color: hsl(120, 100%, 40%);">+                   (EC_FEATURE_UNIFIED_WAKE_MASKS) > 0 ? UHEPI_SUPPORTED :</span><br><span>                   UHEPI_NOT_SUPPORTED;</span><br><span>                 printk(BIOS_DEBUG, "Chrome EC: UHEPI %s\n",</span><br><span>                        uhepi_support == UHEPI_SUPPORTED ?</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/24982">change 24982</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/24982"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7846efb340bc1546b074e8502daf906c444bd146 </div>
<div style="display:none"> Gerrit-Change-Number: 24982 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>