[coreboot-gerrit] Change in coreboot[master]: google/snappy: enhance CCD type-A USB 2.0 phy strength

Kevin Chiu (Code Review) gerrit at coreboot.org
Fri Mar 2 04:56:30 CET 2018


Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/24969


Change subject: google/snappy: enhance CCD type-A USB 2.0 phy strength
......................................................................

google/snappy: enhance CCD type-A USB 2.0 phy strength

Alan(11")/BigDaddy(14") right type-A(port#2), CCD(port#4) are occasionally
undetectable.
USB 2.0 phy will need to override to enhance strength.

right type-A port#2
PERPORTPETXISET: 4
PERPORTTXISET: 4
IUSBTXEMPHASISEN: 1
PERPORTTXPEHALF: 0

CCD port#4
PERPORTPETXISET: 7
PERPORTTXISET: 7
IUSBTXEMPHASISEN: 1
PERPORTTXPEHALF: 0

BUG=b:72922816
BRANCH=reef
TEST=emerge-snappy coreboot
Change-Id: I2b18c11709280d00ec3a6ef10f93a416acb4fb45
Signed-off-by: Kevin Chiu <Kevin.Chiu at quantatw.com>
---
M src/mainboard/google/reef/variants/snappy/mainboard.c
1 file changed, 21 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/24969/1

diff --git a/src/mainboard/google/reef/variants/snappy/mainboard.c b/src/mainboard/google/reef/variants/snappy/mainboard.c
index 990f483..a625c60 100644
--- a/src/mainboard/google/reef/variants/snappy/mainboard.c
+++ b/src/mainboard/google/reef/variants/snappy/mainboard.c
@@ -89,12 +89,33 @@
 	sku_id = variant_board_sku();
 
 	switch (sku_id) {
+	case SKU_ALAN:
+		cfg->usb2eye[2].Usb20PerPortPeTxiSet = 4;
+		cfg->usb2eye[2].Usb20PerPortTxiSet = 4;
+		cfg->usb2eye[2].Usb20IUsbTxEmphasisEn = 1;
+		cfg->usb2eye[2].Usb20PerPortTxPeHalf = 0;
+
+		cfg->usb2eye[4].Usb20PerPortPeTxiSet = 7;
+		cfg->usb2eye[4].Usb20PerPortTxiSet = 7;
+		cfg->usb2eye[4].Usb20IUsbTxEmphasisEn = 1;
+		cfg->usb2eye[4].Usb20PerPortTxPeHalf = 0;
+		break;
 	case SKU_BIGDADDY_KBDBKLIGHT:
 	case SKU_BIGDADDY:
 		cfg->usb2eye[1].Usb20PerPortPeTxiSet = 7;
 		cfg->usb2eye[1].Usb20PerPortTxiSet = 1;
 		cfg->usb2eye[1].Usb20IUsbTxEmphasisEn = 3;
 		cfg->usb2eye[1].Usb20PerPortTxPeHalf = 0;
+
+		cfg->usb2eye[2].Usb20PerPortPeTxiSet = 4;
+		cfg->usb2eye[2].Usb20PerPortTxiSet = 4;
+		cfg->usb2eye[2].Usb20IUsbTxEmphasisEn = 1;
+		cfg->usb2eye[2].Usb20PerPortTxPeHalf = 0;
+
+		cfg->usb2eye[4].Usb20PerPortPeTxiSet = 7;
+		cfg->usb2eye[4].Usb20PerPortTxiSet = 7;
+		cfg->usb2eye[4].Usb20IUsbTxEmphasisEn = 1;
+		cfg->usb2eye[4].Usb20PerPortTxPeHalf = 0;
 		break;
 	default:
 		break;

-- 
To view, visit https://review.coreboot.org/24969
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b18c11709280d00ec3a6ef10f93a416acb4fb45
Gerrit-Change-Number: 24969
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <Kevin.Chiu at quantatw.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180302/020dfdcd/attachment.html>


More information about the coreboot-gerrit mailing list