<p>Kevin Chiu has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/24969">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/snappy: enhance CCD type-A USB 2.0 phy strength<br><br>Alan(11")/BigDaddy(14") right type-A(port#2), CCD(port#4) are occasionally<br>undetectable.<br>USB 2.0 phy will need to override to enhance strength.<br><br>right type-A port#2<br>PERPORTPETXISET: 4<br>PERPORTTXISET: 4<br>IUSBTXEMPHASISEN: 1<br>PERPORTTXPEHALF: 0<br><br>CCD port#4<br>PERPORTPETXISET: 7<br>PERPORTTXISET: 7<br>IUSBTXEMPHASISEN: 1<br>PERPORTTXPEHALF: 0<br><br>BUG=b:72922816<br>BRANCH=reef<br>TEST=emerge-snappy coreboot<br>Change-Id: I2b18c11709280d00ec3a6ef10f93a416acb4fb45<br>Signed-off-by: Kevin Chiu <Kevin.Chiu@quantatw.com><br>---<br>M src/mainboard/google/reef/variants/snappy/mainboard.c<br>1 file changed, 21 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/24969/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/reef/variants/snappy/mainboard.c b/src/mainboard/google/reef/variants/snappy/mainboard.c</span><br><span>index 990f483..a625c60 100644</span><br><span>--- a/src/mainboard/google/reef/variants/snappy/mainboard.c</span><br><span>+++ b/src/mainboard/google/reef/variants/snappy/mainboard.c</span><br><span>@@ -89,12 +89,33 @@</span><br><span>      sku_id = variant_board_sku();</span><br><span> </span><br><span>    switch (sku_id) {</span><br><span style="color: hsl(120, 100%, 40%);">+     case SKU_ALAN:</span><br><span style="color: hsl(120, 100%, 40%);">+                cfg->usb2eye[2].Usb20PerPortPeTxiSet = 4;</span><br><span style="color: hsl(120, 100%, 40%);">+          cfg->usb2eye[2].Usb20PerPortTxiSet = 4;</span><br><span style="color: hsl(120, 100%, 40%);">+            cfg->usb2eye[2].Usb20IUsbTxEmphasisEn = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+         cfg->usb2eye[2].Usb20PerPortTxPeHalf = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                cfg->usb2eye[4].Usb20PerPortPeTxiSet = 7;</span><br><span style="color: hsl(120, 100%, 40%);">+          cfg->usb2eye[4].Usb20PerPortTxiSet = 7;</span><br><span style="color: hsl(120, 100%, 40%);">+            cfg->usb2eye[4].Usb20IUsbTxEmphasisEn = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+         cfg->usb2eye[4].Usb20PerPortTxPeHalf = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+          break;</span><br><span>       case SKU_BIGDADDY_KBDBKLIGHT:</span><br><span>        case SKU_BIGDADDY:</span><br><span>           cfg->usb2eye[1].Usb20PerPortPeTxiSet = 7;</span><br><span>                 cfg->usb2eye[1].Usb20PerPortTxiSet = 1;</span><br><span>           cfg->usb2eye[1].Usb20IUsbTxEmphasisEn = 3;</span><br><span>                cfg->usb2eye[1].Usb20PerPortTxPeHalf = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                cfg->usb2eye[2].Usb20PerPortPeTxiSet = 4;</span><br><span style="color: hsl(120, 100%, 40%);">+          cfg->usb2eye[2].Usb20PerPortTxiSet = 4;</span><br><span style="color: hsl(120, 100%, 40%);">+            cfg->usb2eye[2].Usb20IUsbTxEmphasisEn = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+         cfg->usb2eye[2].Usb20PerPortTxPeHalf = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                cfg->usb2eye[4].Usb20PerPortPeTxiSet = 7;</span><br><span style="color: hsl(120, 100%, 40%);">+          cfg->usb2eye[4].Usb20PerPortTxiSet = 7;</span><br><span style="color: hsl(120, 100%, 40%);">+            cfg->usb2eye[4].Usb20IUsbTxEmphasisEn = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+         cfg->usb2eye[4].Usb20PerPortTxPeHalf = 0;</span><br><span>                 break;</span><br><span>       default:</span><br><span>             break;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/24969">change 24969</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/24969"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I2b18c11709280d00ec3a6ef10f93a416acb4fb45 </div>
<div style="display:none"> Gerrit-Change-Number: 24969 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kevin Chiu <Kevin.Chiu@quantatw.com> </div>