[coreboot-gerrit] Change in coreboot[master]: sb/intel/common/smihandler: Use new PMBASE API

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Fri Jun 29 10:49:58 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27281 )

Change subject: sb/intel/common/smihandler: Use new PMBASE API
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/27281/1/src/southbridge/intel/common/smihandler.c
File src/southbridge/intel/common/smihandler.c:

https://review.coreboot.org/#/c/27281/1/src/southbridge/intel/common/smihandler.c@289
PS1, Line 289: 		write_pmbase32(PM1_CNT, read_pmbase32(PM1_CNT) &~SCI_EN);
need consistent spacing around '&' (ctx:WxO)



-- 
To view, visit https://review.coreboot.org/27281
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c64233ecdb8c1e28b319d84149f34bc8f1e4b97
Gerrit-Change-Number: 27281
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 29 Jun 2018 08:49:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180629/985070f0/attachment.html>


More information about the coreboot-gerrit mailing list