[coreboot-gerrit] Change in coreboot[master]: smmstore: Add a key/val store facility in flash, mediated through SMM

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25182 )

Change subject: smmstore: Add a key/val store facility in flash, mediated through SMM
......................................................................


Patch Set 6:

(16 comments)

https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/smi.c
File src/drivers/smmstore/smi.c:

https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/smi.c@30
PS6, Line 30: static int range_check(void *start, size_t size) {
open brace '{' following function declarations go on the next line


https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/smi.c@36
PS6, Line 36: u32 smmstore_exec(u8 command, void* param)
"foo* bar" should be "foo *bar"


https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/smi.c@43
PS6, Line 43: 		struct smmstore_params_read *params = (struct smmstore_params_read *)param;
line over 80 characters


https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/smi.c@56
PS6, Line 56: 		struct smmstore_params_append *params = (struct smmstore_params_append *)param;
line over 80 characters


https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/smi.c@76
PS6, Line 76: 		printk(BIOS_DEBUG, "Unknown SMM store command: 0x%02x\n", command);
line over 80 characters


https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c
File src/drivers/smmstore/store.c:

https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@60
PS6, Line 60: 	if (cbfs_locate_file_in_region(&file, CONFIG_SMMSTORE_REGION, CONFIG_SMMSTORE_FILENAME, NULL) < 0) {
line over 80 characters


https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@61
PS6, Line 61: 		printk(BIOS_WARNING, "smm store: Unable to find SMM store file in region '%s'\n", CONFIG_SMMSTORE_REGION);
line over 80 characters


https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@108
PS6, Line 108: int smmstore_append_data(void *key, uint32_t key_sz, void *value, uint32_t value_sz)
line over 80 characters


https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@161
PS6, Line 161: 		printk(BIOS_WARNING, "eof of data marker looks invalid: 0x%x\n", k_sz);
line over 80 characters


https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@167
PS6, Line 167: 	printk(BIOS_WARNING, "open (%zx, %zx) for writing\n", store.region.offset, store.region.size);
line over 80 characters


https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@179
PS6, Line 179: 	if (rdev_writeat(&store, &key_sz, end, 4) != 4) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@183
PS6, Line 183: 	if (rdev_writeat(&store, &value_sz, end, 4) != 4) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@187
PS6, Line 187: 	if (rdev_writeat(&store, key, end, key_sz) != key_sz) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@191
PS6, Line 191: 	if (rdev_writeat(&store, value, end, value_sz) != value_sz) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@196
PS6, Line 196: 	if (rdev_writeat(&store, &nul, end, 1) != 1) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/25182/6/src/include/smmstore.h
File src/include/smmstore.h:

https://review.coreboot.org/#/c/25182/6/src/include/smmstore.h@49
PS6, Line 49: int smmstore_append_data(void *key, uint32_t key_sz, void *value, uint32_t value_sz);
line over 80 characters



-- 
To view, visit https://review.coreboot.org/25182
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9553922f9dfa60b9d4b3576973ad4b84d3fe2fb5
Gerrit-Change-Number: 25182
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Thu, 28 Jun 2018 16:17:32 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180628/cf682259/attachment.html>