<p><a href="https://review.coreboot.org/25182">View Change</a></p><p>16 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/smi.c">File src/drivers/smmstore/smi.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/smi.c@30">Patch Set #6, Line 30:</a> <code style="font-family:monospace,monospace">static int range_check(void *start, size_t size) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">open brace '{' following function declarations go on the next line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/smi.c@36">Patch Set #6, Line 36:</a> <code style="font-family:monospace,monospace">u32 smmstore_exec(u8 command, void* param)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/smi.c@43">Patch Set #6, Line 43:</a> <code style="font-family:monospace,monospace"> struct smmstore_params_read *params = (struct smmstore_params_read *)param;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/smi.c@56">Patch Set #6, Line 56:</a> <code style="font-family:monospace,monospace"> struct smmstore_params_append *params = (struct smmstore_params_append *)param;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/smi.c@76">Patch Set #6, Line 76:</a> <code style="font-family:monospace,monospace"> printk(BIOS_DEBUG, "Unknown SMM store command: 0x%02x\n", command);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c">File src/drivers/smmstore/store.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@60">Patch Set #6, Line 60:</a> <code style="font-family:monospace,monospace"> if (cbfs_locate_file_in_region(&file, CONFIG_SMMSTORE_REGION, CONFIG_SMMSTORE_FILENAME, NULL) < 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@61">Patch Set #6, Line 61:</a> <code style="font-family:monospace,monospace"> printk(BIOS_WARNING, "smm store: Unable to find SMM store file in region '%s'\n", CONFIG_SMMSTORE_REGION);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@108">Patch Set #6, Line 108:</a> <code style="font-family:monospace,monospace">int smmstore_append_data(void *key, uint32_t key_sz, void *value, uint32_t value_sz)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@161">Patch Set #6, Line 161:</a> <code style="font-family:monospace,monospace"> printk(BIOS_WARNING, "eof of data marker looks invalid: 0x%x\n", k_sz);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@167">Patch Set #6, Line 167:</a> <code style="font-family:monospace,monospace"> printk(BIOS_WARNING, "open (%zx, %zx) for writing\n", store.region.offset, store.region.size);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@179">Patch Set #6, Line 179:</a> <code style="font-family:monospace,monospace"> if (rdev_writeat(&store, &key_sz, end, 4) != 4) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@183">Patch Set #6, Line 183:</a> <code style="font-family:monospace,monospace"> if (rdev_writeat(&store, &value_sz, end, 4) != 4) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@187">Patch Set #6, Line 187:</a> <code style="font-family:monospace,monospace"> if (rdev_writeat(&store, key, end, key_sz) != key_sz) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@191">Patch Set #6, Line 191:</a> <code style="font-family:monospace,monospace"> if (rdev_writeat(&store, value, end, value_sz) != value_sz) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25182/6/src/drivers/smmstore/store.c@196">Patch Set #6, Line 196:</a> <code style="font-family:monospace,monospace"> if (rdev_writeat(&store, &nul, end, 1) != 1) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25182/6/src/include/smmstore.h">File src/include/smmstore.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25182/6/src/include/smmstore.h@49">Patch Set #6, Line 49:</a> <code style="font-family:monospace,monospace">int smmstore_append_data(void *key, uint32_t key_sz, void *value, uint32_t value_sz);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/25182">change 25182</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25182"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I9553922f9dfa60b9d4b3576973ad4b84d3fe2fb5 </div>
<div style="display:none"> Gerrit-Change-Number: 25182 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 28 Jun 2018 16:17:32 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>