[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Enable early mmc CMD0, CMD1 for GLK

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25514 )

Change subject: soc/intel/apollolake: Enable early mmc CMD0, CMD1 for GLK
......................................................................


Patch Set 5:

(6 comments)

https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/early_mmc.c
File src/soc/intel/apollolake/early_mmc.c:

https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/early_mmc.c@25
PS5, Line 25: 	PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_104, UP_20K, DEEP, NF1),/*EMMC_DNX_PWR_EN_B*/
line over 80 characters


https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/early_mmc.c@37
PS5, Line 37: 	PAD_CFG_NF_IOSSTATE(GPIO_209, DN_20K, DEEP, NF1, HIZCRx0)/*EMMC0_STROBE*/
line over 80 characters


https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/early_mmc.c@61
PS5, Line 61:                        __func__);
code indent should use tabs where possible


https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/early_mmc.c@61
PS5, Line 61:                        __func__);
please, no spaces at the start of a line


https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/romstage.c
File src/soc/intel/apollolake/romstage.c:

https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/romstage.c@207
PS5, Line 207: 			printk(BIOS_DEBUG, "Early mmc initilization failed \n");
'initilization' may be misspelled - perhaps 'initialization'?


https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/romstage.c@207
PS5, Line 207: 			printk(BIOS_DEBUG, "Early mmc initilization failed \n");
unnecessary whitespace before a quoted newline



-- 
To view, visit https://review.coreboot.org/25514
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4e791607059d12b3f5692f6404cb9eb39d79f6d
Gerrit-Change-Number: 25514
Gerrit-PatchSet: 5
Gerrit-Owner: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 28 Jun 2018 00:40:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180628/082e5651/attachment.html>