<p><a href="https://review.coreboot.org/25514">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/early_mmc.c">File src/soc/intel/apollolake/early_mmc.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/early_mmc.c@25">Patch Set #5, Line 25:</a> <code style="font-family:monospace,monospace">     PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_104, UP_20K, DEEP, NF1),/*EMMC_DNX_PWR_EN_B*/</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/early_mmc.c@37">Patch Set #5, Line 37:</a> <code style="font-family:monospace,monospace">  PAD_CFG_NF_IOSSTATE(GPIO_209, DN_20K, DEEP, NF1, HIZCRx0)/*EMMC0_STROBE*/</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/early_mmc.c@61">Patch Set #5, Line 61:</a> <code style="font-family:monospace,monospace">                       __func__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/early_mmc.c@61">Patch Set #5, Line 61:</a> <code style="font-family:monospace,monospace">                       __func__);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/romstage.c">File src/soc/intel/apollolake/romstage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/romstage.c@207">Patch Set #5, Line 207:</a> <code style="font-family:monospace,monospace">                 printk(BIOS_DEBUG, "Early mmc initilization failed \n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">'initilization' may be misspelled - perhaps 'initialization'?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/romstage.c@207">Patch Set #5, Line 207:</a> <code style="font-family:monospace,monospace">                       printk(BIOS_DEBUG, "Early mmc initilization failed \n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">unnecessary whitespace before a quoted newline</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/25514">change 25514</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25514"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ib4e791607059d12b3f5692f6404cb9eb39d79f6d </div>
<div style="display:none"> Gerrit-Change-Number: 25514 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Bora Guvendik <bora.guvendik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Bora Guvendik <bora.guvendik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Hannah Williams <hannah.williams@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 28 Jun 2018 00:40:14 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>