[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nocturne: fix FPMCU IRQ sensitivity

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/27221 )

Change subject: mb/google/poppy/variants/nocturne: fix FPMCU IRQ sensitivity
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/27221/1/src/mainboard/google/poppy/variants/nocturne/gpio.c
File src/mainboard/google/poppy/variants/nocturne/gpio.c:

https://review.coreboot.org/#/c/27221/1/src/mainboard/google/poppy/variants/nocturne/gpio.c@138
PS1, Line 138: NONE
> If signal is active low, why did you change this definition from "_INVERT" ?  IF it's a double-mappi […]
I've talked with Duncan and Aaron about this, and they have better explained to me how and where the various definitions come into play, and based on their input, your change with regard to removing "_INVERT" should be fine, please ignore my last comment.



-- 
To view, visit https://review.coreboot.org/27221
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56c13c797b133dd22669a2299bcd16ef14eed335
Gerrit-Change-Number: 27221
Gerrit-PatchSet: 1
Gerrit-Owner: Vincent Palatin <vpalatin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Vincent Palatin <vpalatin at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Comment-Date: Wed, 27 Jun 2018 18:35:55 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180627/5c7ec4ae/attachment.html>