[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nocturne: fix FPMCU IRQ sensitivity

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/27221 )

Change subject: mb/google/poppy/variants/nocturne: fix FPMCU IRQ sensitivity
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/27221/1/src/mainboard/google/poppy/variants/nocturne/gpio.c
File src/mainboard/google/poppy/variants/nocturne/gpio.c:

https://review.coreboot.org/#/c/27221/1/src/mainboard/google/poppy/variants/nocturne/gpio.c@138
PS1, Line 138: NONE
> As mentioned in b/78613978#comment10 given this is an active-low interrupt, the pull-down is doing t […]
If signal is active low, why did you change this definition from "_INVERT" ?  IF it's a double-mapping issue with kernel, the kernel is where it should be changed, IMO; this file should map to how the hardware actually behaves.



-- 
To view, visit https://review.coreboot.org/27221
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56c13c797b133dd22669a2299bcd16ef14eed335
Gerrit-Change-Number: 27221
Gerrit-PatchSet: 1
Gerrit-Owner: Vincent Palatin <vpalatin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Vincent Palatin <vpalatin at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Comment-Date: Wed, 27 Jun 2018 16:46:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180627/5298bad8/attachment.html>