[coreboot-gerrit] Change in coreboot[master]: cbfstool: Update FIT entries in the second bootblock

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26836 )

Change subject: cbfstool: Update FIT entries in the second bootblock
......................................................................


Patch Set 17:

(4 comments)

https://review.coreboot.org/#/c/26836/17/util/cbfstool/cbfstool.c
File util/cbfstool/cbfstool.c:

https://review.coreboot.org/#/c/26836/17/util/cbfstool/cbfstool.c@1486
PS17, Line 1486: 	     "        -x EMTPY_FIT_ENTRIES \\                         \n"
unnecessary whitespace before a quoted newline


https://review.coreboot.org/#/c/26836/17/util/cbfstool/cbfstool.c@1490
PS17, Line 1490: 	     "    ucode-region is a region in the FMAP, its address is \n"
unnecessary whitespace before a quoted newline


https://review.coreboot.org/#/c/26836/17/util/cbfstool/cbfstool.c@1492
PS17, Line 1492: 	     "    inserted as the first entry in the topswap FIT.  \n"
unnecessary whitespace before a quoted newline


https://review.coreboot.org/#/c/26836/17/util/cbfstool/fit.c
File util/cbfstool/fit.c:

https://review.coreboot.org/#/c/26836/17/util/cbfstool/fit.c@348
PS17, Line 348: 				ERROR("No room, blob mcus = %d, total entries = %d\n",
line over 80 characters



-- 
To view, visit https://review.coreboot.org/26836
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a417031c279038903cdf1761a791f2da0fe8644
Gerrit-Change-Number: 26836
Gerrit-PatchSet: 17
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-Comment-Date: Tue, 26 Jun 2018 05:46:32 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180626/cfed8e8c/attachment.html>