<p><a href="https://review.coreboot.org/26836">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26836/17/util/cbfstool/cbfstool.c">File util/cbfstool/cbfstool.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26836/17/util/cbfstool/cbfstool.c@1486">Patch Set #17, Line 1486:</a> <code style="font-family:monospace,monospace">       "        -x EMTPY_FIT_ENTRIES \\                         \n"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">unnecessary whitespace before a quoted newline</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26836/17/util/cbfstool/cbfstool.c@1490">Patch Set #17, Line 1490:</a> <code style="font-family:monospace,monospace">         "    ucode-region is a region in the FMAP, its address is \n"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">unnecessary whitespace before a quoted newline</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26836/17/util/cbfstool/cbfstool.c@1492">Patch Set #17, Line 1492:</a> <code style="font-family:monospace,monospace">        "    inserted as the first entry in the topswap FIT.  \n"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">unnecessary whitespace before a quoted newline</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26836/17/util/cbfstool/fit.c">File util/cbfstool/fit.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26836/17/util/cbfstool/fit.c@348">Patch Set #17, Line 348:</a> <code style="font-family:monospace,monospace">                              ERROR("No room, blob mcus = %d, total entries = %d\n",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/26836">change 26836</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26836"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I9a417031c279038903cdf1761a791f2da0fe8644 </div>
<div style="display:none"> Gerrit-Change-Number: 26836 </div>
<div style="display:none"> Gerrit-PatchSet: 17 </div>
<div style="display:none"> Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Naresh Solanki <naresh.solanki@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma@intel.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 26 Jun 2018 05:46:32 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>