[coreboot-gerrit] Change in coreboot[master]: cbfstool: add an option for creating a topswap bootblock
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Tue Jun 26 07:46:24 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22537 )
Change subject: cbfstool: add an option for creating a topswap bootblock
......................................................................
Patch Set 25:
(3 comments)
https://review.coreboot.org/#/c/22537/25/util/cbfstool/cbfstool.c
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/#/c/22537/25/util/cbfstool/cbfstool.c@276
PS25, Line 276: ERROR("Invalid topswap_size %d, topswap can be 64K|128K|256K|512K|1M\n",
line over 80 characters
https://review.coreboot.org/#/c/22537/25/util/cbfstool/cbfstool.c@1420
PS25, Line 1420: " -j valid size: 0x10000 0x20000 0x40000 0x80000 0x100000 \n"
unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/22537/25/util/cbfstool/cbfstool.c@1435
PS25, Line 1435: " add-master-header [-r image,regions] \\ \n"
unnecessary whitespace before a quoted newline
--
To view, visit https://review.coreboot.org/22537
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e455dc8b7f54e55f2229491695cf4218d9cfef8
Gerrit-Change-Number: 22537
Gerrit-PatchSet: 25
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-CC: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Comment-Date: Tue, 26 Jun 2018 05:46:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180626/be7778c9/attachment.html>
More information about the coreboot-gerrit
mailing list