<p><a href="https://review.coreboot.org/22537">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/22537/25/util/cbfstool/cbfstool.c">File util/cbfstool/cbfstool.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22537/25/util/cbfstool/cbfstool.c@276">Patch Set #25, Line 276:</a> <code style="font-family:monospace,monospace">            ERROR("Invalid topswap_size %d, topswap can be 64K|128K|256K|512K|1M\n",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22537/25/util/cbfstool/cbfstool.c@1420">Patch Set #25, Line 1420:</a> <code style="font-family:monospace,monospace">         "    -j valid size: 0x10000 0x20000 0x40000 0x80000 0x100000 \n"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">unnecessary whitespace before a quoted newline</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22537/25/util/cbfstool/cbfstool.c@1435">Patch Set #25, Line 1435:</a> <code style="font-family:monospace,monospace">             " add-master-header [-r image,regions] \\                   \n"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">unnecessary whitespace before a quoted newline</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/22537">change 22537</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22537"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I3e455dc8b7f54e55f2229491695cf4218d9cfef8 </div>
<div style="display:none"> Gerrit-Change-Number: 22537 </div>
<div style="display:none"> Gerrit-PatchSet: 25 </div>
<div style="display:none"> Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Hannah Williams <hannah.williams@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma@intel.com> </div>
<div style="display:none"> Gerrit-CC: Naresh Solanki <naresh.solanki@intel.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 26 Jun 2018 05:46:24 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>