[coreboot-gerrit] Change in coreboot[master]: drivers/i2c/alps: Get rid of i2c/alps driver

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/27208


Change subject: drivers/i2c/alps: Get rid of i2c/alps driver
......................................................................

drivers/i2c/alps: Get rid of i2c/alps driver

i2c/alps driver implementation is an exact copy of the i2c/hid driver
with only the addition of ALPS0001_HID. This can be supported by the
i2c/hid driver using the hid field in devicetree which is what glkrvp
mainboard does. So, this change removes the i2c/alps driver which is
anyways unused.

Change-Id: I60761c384f3d800532b2b346272da7be28b77acd
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
D src/drivers/i2c/alps/Kconfig
D src/drivers/i2c/alps/Makefile.inc
D src/drivers/i2c/alps/alps.c
D src/drivers/i2c/alps/chip.h
4 files changed, 0 insertions(+), 94 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/27208/1

diff --git a/src/drivers/i2c/alps/Kconfig b/src/drivers/i2c/alps/Kconfig
deleted file mode 100644
index b49581d..0000000
--- a/src/drivers/i2c/alps/Kconfig
+++ /dev/null
@@ -1,3 +0,0 @@
-config DRIVERS_I2C_ALPS
-	bool
-	select DRIVERS_I2C_GENERIC
diff --git a/src/drivers/i2c/alps/Makefile.inc b/src/drivers/i2c/alps/Makefile.inc
deleted file mode 100644
index aa18034..0000000
--- a/src/drivers/i2c/alps/Makefile.inc
+++ /dev/null
@@ -1 +0,0 @@
-ramstage-$(CONFIG_DRIVERS_I2C_ALPS) += alps.c
diff --git a/src/drivers/i2c/alps/alps.c b/src/drivers/i2c/alps/alps.c
deleted file mode 100644
index 2862374..0000000
--- a/src/drivers/i2c/alps/alps.c
+++ /dev/null
@@ -1,60 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2016 Intel Corporation.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
-
-#include <arch/acpigen_dsm.h>
-#include <device/device.h>
-#include <stdint.h>
-#include "chip.h"
-
-static void i2c_alps_fill_dsm(struct device *dev)
-{
-	struct drivers_i2c_alps_config *config = dev->chip_info;
-	struct dsm_i2c_hid_config dsm_config = {
-		.hid_desc_reg_offset = config->hid_desc_reg_offset,
-	};
-
-	acpigen_write_dsm_i2c_hid(&dsm_config);
-}
-
-static void i2c_alps_fill_ssdt_generator(struct device *dev)
-{
-	struct drivers_i2c_alps_config *config = dev->chip_info;
-	i2c_generic_fill_ssdt(dev, &i2c_alps_fill_dsm, &config->generic);
-}
-
-static const char *i2c_alps_acpi_name(const struct device *dev)
-{
-	return "ALPS";
-}
-
-static struct device_operations i2c_alps_ops = {
-	.read_resources		  = DEVICE_NOOP,
-	.set_resources		  = DEVICE_NOOP,
-	.enable_resources	  = DEVICE_NOOP,
-#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
-	.acpi_name		  = &i2c_alps_acpi_name,
-	.acpi_fill_ssdt_generator = &i2c_alps_fill_ssdt_generator,
-#endif
-};
-
-static void i2c_alps_enable(struct device *dev)
-{
-	dev->ops = &i2c_alps_ops;
-}
-
-struct chip_operations drivers_i2c_alps_ops = {
-	CHIP_NAME("ALPS I2C Device")
-	.enable_dev = &i2c_alps_enable
-};
diff --git a/src/drivers/i2c/alps/chip.h b/src/drivers/i2c/alps/chip.h
deleted file mode 100644
index fb0b0fa..0000000
--- a/src/drivers/i2c/alps/chip.h
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2016 Intel Corporation.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
-
-#ifndef __I2C_ALPS_CHIP_H__
-#define __I2C_ALPS_CHIP_H__
-
-#include <drivers/i2c/generic/chip.h>
-
-#define ALPS0001_HID		"ALPS0001"
-#define PNP0C50_CID		"PNP0C50"
-#define ALPS_TP_DESC		"ALPS Touchpad"
-
-struct drivers_i2c_alps_config {
-	struct drivers_i2c_generic_config generic;
-	uint8_t hid_desc_reg_offset;
-};
-
-#endif /* __I2C_ALPS_CHIP_H__ */

-- 
To view, visit https://review.coreboot.org/27208
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I60761c384f3d800532b2b346272da7be28b77acd
Gerrit-Change-Number: 27208
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180622/f9dad898/attachment-0001.html>