<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27208">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">drivers/i2c/alps: Get rid of i2c/alps driver<br><br>i2c/alps driver implementation is an exact copy of the i2c/hid driver<br>with only the addition of ALPS0001_HID. This can be supported by the<br>i2c/hid driver using the hid field in devicetree which is what glkrvp<br>mainboard does. So, this change removes the i2c/alps driver which is<br>anyways unused.<br><br>Change-Id: I60761c384f3d800532b2b346272da7be28b77acd<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>D src/drivers/i2c/alps/Kconfig<br>D src/drivers/i2c/alps/Makefile.inc<br>D src/drivers/i2c/alps/alps.c<br>D src/drivers/i2c/alps/chip.h<br>4 files changed, 0 insertions(+), 94 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/27208/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/i2c/alps/Kconfig b/src/drivers/i2c/alps/Kconfig</span><br><span>deleted file mode 100644</span><br><span>index b49581d..0000000</span><br><span>--- a/src/drivers/i2c/alps/Kconfig</span><br><span>+++ /dev/null</span><br><span>@@ -1,3 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-config DRIVERS_I2C_ALPS</span><br><span style="color: hsl(0, 100%, 40%);">- bool</span><br><span style="color: hsl(0, 100%, 40%);">- select DRIVERS_I2C_GENERIC</span><br><span>diff --git a/src/drivers/i2c/alps/Makefile.inc b/src/drivers/i2c/alps/Makefile.inc</span><br><span>deleted file mode 100644</span><br><span>index aa18034..0000000</span><br><span>--- a/src/drivers/i2c/alps/Makefile.inc</span><br><span>+++ /dev/null</span><br><span>@@ -1 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-ramstage-$(CONFIG_DRIVERS_I2C_ALPS) += alps.c</span><br><span>diff --git a/src/drivers/i2c/alps/alps.c b/src/drivers/i2c/alps/alps.c</span><br><span>deleted file mode 100644</span><br><span>index 2862374..0000000</span><br><span>--- a/src/drivers/i2c/alps/alps.c</span><br><span>+++ /dev/null</span><br><span>@@ -1,60 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(0, 100%, 40%);">- * This file is part of the coreboot project.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * Copyright (C) 2016 Intel Corporation.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(0, 100%, 40%);">- * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(0, 100%, 40%);">- * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(0, 100%, 40%);">- * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(0, 100%, 40%);">- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(0, 100%, 40%);">- * GNU General Public License for more details.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpigen_dsm.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/device.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <stdint.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include "chip.h"</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-static void i2c_alps_fill_dsm(struct device *dev)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- struct drivers_i2c_alps_config *config = dev->chip_info;</span><br><span style="color: hsl(0, 100%, 40%);">- struct dsm_i2c_hid_config dsm_config = {</span><br><span style="color: hsl(0, 100%, 40%);">- .hid_desc_reg_offset = config->hid_desc_reg_offset,</span><br><span style="color: hsl(0, 100%, 40%);">- };</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- acpigen_write_dsm_i2c_hid(&dsm_config);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-static void i2c_alps_fill_ssdt_generator(struct device *dev)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- struct drivers_i2c_alps_config *config = dev->chip_info;</span><br><span style="color: hsl(0, 100%, 40%);">- i2c_generic_fill_ssdt(dev, &i2c_alps_fill_dsm, &config->generic);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-static const char *i2c_alps_acpi_name(const struct device *dev)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- return "ALPS";</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-static struct device_operations i2c_alps_ops = {</span><br><span style="color: hsl(0, 100%, 40%);">- .read_resources = DEVICE_NOOP,</span><br><span style="color: hsl(0, 100%, 40%);">- .set_resources = DEVICE_NOOP,</span><br><span style="color: hsl(0, 100%, 40%);">- .enable_resources = DEVICE_NOOP,</span><br><span style="color: hsl(0, 100%, 40%);">-#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)</span><br><span style="color: hsl(0, 100%, 40%);">- .acpi_name = &i2c_alps_acpi_name,</span><br><span style="color: hsl(0, 100%, 40%);">- .acpi_fill_ssdt_generator = &i2c_alps_fill_ssdt_generator,</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(0, 100%, 40%);">-};</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-static void i2c_alps_enable(struct device *dev)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- dev->ops = &i2c_alps_ops;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-struct chip_operations drivers_i2c_alps_ops = {</span><br><span style="color: hsl(0, 100%, 40%);">- CHIP_NAME("ALPS I2C Device")</span><br><span style="color: hsl(0, 100%, 40%);">- .enable_dev = &i2c_alps_enable</span><br><span style="color: hsl(0, 100%, 40%);">-};</span><br><span>diff --git a/src/drivers/i2c/alps/chip.h b/src/drivers/i2c/alps/chip.h</span><br><span>deleted file mode 100644</span><br><span>index fb0b0fa..0000000</span><br><span>--- a/src/drivers/i2c/alps/chip.h</span><br><span>+++ /dev/null</span><br><span>@@ -1,30 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(0, 100%, 40%);">- * This file is part of the coreboot project.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * Copyright (C) 2016 Intel Corporation.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(0, 100%, 40%);">- * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(0, 100%, 40%);">- * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(0, 100%, 40%);">- * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(0, 100%, 40%);">- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(0, 100%, 40%);">- * GNU General Public License for more details.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#ifndef __I2C_ALPS_CHIP_H__</span><br><span style="color: hsl(0, 100%, 40%);">-#define __I2C_ALPS_CHIP_H__</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#include <drivers/i2c/generic/chip.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#define ALPS0001_HID "ALPS0001"</span><br><span style="color: hsl(0, 100%, 40%);">-#define PNP0C50_CID "PNP0C50"</span><br><span style="color: hsl(0, 100%, 40%);">-#define ALPS_TP_DESC "ALPS Touchpad"</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-struct drivers_i2c_alps_config {</span><br><span style="color: hsl(0, 100%, 40%);">- struct drivers_i2c_generic_config generic;</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t hid_desc_reg_offset;</span><br><span style="color: hsl(0, 100%, 40%);">-};</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#endif /* __I2C_ALPS_CHIP_H__ */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27208">change 27208</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27208"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I60761c384f3d800532b2b346272da7be28b77acd </div>
<div style="display:none"> Gerrit-Change-Number: 27208 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>