[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nami:Touchscreen gpio setting for Pantheon

[Crystal Lin (Code Review)]

Crystal Lin has uploaded this change for review. ( https://review.coreboot.org/27177


Change subject: mb/google/poppy/variants/nami:Touchscreen gpio setting for Pantheon
......................................................................

mb/google/poppy/variants/nami:Touchscreen gpio setting for Pantheon

We found GPP_C3 keep high when system in S0ix mode.It caused 1.8V
leakage.To fix this problem, add GPP_C3 into config for Pantheon
Synaptics touchscreen.

BUG=b:78436458
BRANCH=None
TEST=Let DUT in S0ix mode and check GPP_C3 is normal.

Change-Id: Idb2dab93178af1dae54265e49522b473b69a35af
---
M src/mainboard/google/poppy/variants/nami/gpio.c
1 file changed, 17 insertions(+), 5 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/27177/1

diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c
index 3c82c2b..2d0fea4 100644
--- a/src/mainboard/google/poppy/variants/nami/gpio.c
+++ b/src/mainboard/google/poppy/variants/nami/gpio.c
@@ -118,8 +118,6 @@
 	PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1),
 	/* C2  : SMBALERT# ==> NC(TP917) */
 	PAD_CFG_NC(GPP_C2),
-	/* C3  : SML0CLK ==> TOUCHSCREEN_DIS# */
-	PAD_CFG_GPO(GPP_C3, 0, DEEP),
 	/* C4  : SML0DATA ==> NC */
 	PAD_CFG_NC(GPP_C4),
 	/* C5  : SML0ALERT# ==> SOC_SML0ALERT# (unstuffed) */
@@ -389,11 +387,22 @@
 static const struct pad_config nami_default_sku_gpio_table[] = {
 	/* D17 : DMIC_CLK1 ==> SOC_DMIC_CLK1 */
 	PAD_CFG_NF(GPP_D17, NONE, DEEP, NF1),
+	/* C3  : SML0CLK ==> TOUCHSCREEN_DIS# */
+	PAD_CFG_GPO(GPP_C3, 0, DEEP),
 };
 
 static const struct pad_config no_dmic1_sku_gpio_table[] = {
 	/* D17 : DMIC_CLK1 ==> NC */
 	PAD_CFG_NC(GPP_D17),
+	/* C3  : SML0CLK ==> TOUCHSCREEN_DIS# */
+	PAD_CFG_GPO(GPP_C3, 0, DEEP),
+};
+
+static const struct pad_config pantheon_gpio_table[] = {
+	/* D17 : DMIC_CLK1 ==> NC */
+	PAD_CFG_NC(GPP_D17),
+	/* C3  : SML0CLK ==> NC */
+	PAD_CFG_NC(GPP_C3),
 };
 
 const struct pad_config *variant_sku_gpio_table(size_t *num)
@@ -404,14 +413,17 @@
 	case SKU_0_VAYNE:
 	case SKU_1_VAYNE:
 	case SKU_2_VAYNE:
-	case SKU_0_PANTHEON:
-	case SKU_1_PANTHEON:
-	case SKU_2_PANTHEON:
 	case SKU_0_SONA:
 	case SKU_1_SONA:
 		*num = ARRAY_SIZE(no_dmic1_sku_gpio_table);
 		board_gpio_tables = no_dmic1_sku_gpio_table;
 		break;
+	case SKU_0_PANTHEON:
+	case SKU_1_PANTHEON:
+	case SKU_2_PANTHEON:
+		*num = ARRAY_SIZE(pantheon_gpio_table);
+		board_gpio_tables = pantheon_gpio_table;
+		break;
 	default:
 		*num = ARRAY_SIZE(nami_default_sku_gpio_table);
 		board_gpio_tables = nami_default_sku_gpio_table;

-- 
To view, visit https://review.coreboot.org/27177
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb2dab93178af1dae54265e49522b473b69a35af
Gerrit-Change-Number: 27177
Gerrit-PatchSet: 1
Gerrit-Owner: Crystal Lin <crystal_lin at compal.corp-partner.google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180621/e291abe8/attachment-0001.html>