<p>Crystal Lin has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27177">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/nami:Touchscreen gpio setting for Pantheon<br><br>We found GPP_C3 keep high when system in S0ix mode.It caused 1.8V<br>leakage.To fix this problem, add GPP_C3 into config for Pantheon<br>Synaptics touchscreen.<br><br>BUG=b:78436458<br>BRANCH=None<br>TEST=Let DUT in S0ix mode and check GPP_C3 is normal.<br><br>Change-Id: Idb2dab93178af1dae54265e49522b473b69a35af<br>---<br>M src/mainboard/google/poppy/variants/nami/gpio.c<br>1 file changed, 17 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/27177/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c</span><br><span>index 3c82c2b..2d0fea4 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nami/gpio.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/nami/gpio.c</span><br><span>@@ -118,8 +118,6 @@</span><br><span>        PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1),</span><br><span>         /* C2  : SMBALERT# ==> NC(TP917) */</span><br><span>       PAD_CFG_NC(GPP_C2),</span><br><span style="color: hsl(0, 100%, 40%);">-     /* C3  : SML0CLK ==> TOUCHSCREEN_DIS# */</span><br><span style="color: hsl(0, 100%, 40%);">-     PAD_CFG_GPO(GPP_C3, 0, DEEP),</span><br><span>        /* C4  : SML0DATA ==> NC */</span><br><span>       PAD_CFG_NC(GPP_C4),</span><br><span>  /* C5  : SML0ALERT# ==> SOC_SML0ALERT# (unstuffed) */</span><br><span>@@ -389,11 +387,22 @@</span><br><span> static const struct pad_config nami_default_sku_gpio_table[] = {</span><br><span>         /* D17 : DMIC_CLK1 ==> SOC_DMIC_CLK1 */</span><br><span>   PAD_CFG_NF(GPP_D17, NONE, DEEP, NF1),</span><br><span style="color: hsl(120, 100%, 40%);">+ /* C3  : SML0CLK ==> TOUCHSCREEN_DIS# */</span><br><span style="color: hsl(120, 100%, 40%);">+   PAD_CFG_GPO(GPP_C3, 0, DEEP),</span><br><span> };</span><br><span> </span><br><span> static const struct pad_config no_dmic1_sku_gpio_table[] = {</span><br><span>      /* D17 : DMIC_CLK1 ==> NC */</span><br><span>      PAD_CFG_NC(GPP_D17),</span><br><span style="color: hsl(120, 100%, 40%);">+  /* C3  : SML0CLK ==> TOUCHSCREEN_DIS# */</span><br><span style="color: hsl(120, 100%, 40%);">+   PAD_CFG_GPO(GPP_C3, 0, DEEP),</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static const struct pad_config pantheon_gpio_table[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* D17 : DMIC_CLK1 ==> NC */</span><br><span style="color: hsl(120, 100%, 40%);">+       PAD_CFG_NC(GPP_D17),</span><br><span style="color: hsl(120, 100%, 40%);">+  /* C3  : SML0CLK ==> NC */</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_CFG_NC(GPP_C3),</span><br><span> };</span><br><span> </span><br><span> const struct pad_config *variant_sku_gpio_table(size_t *num)</span><br><span>@@ -404,14 +413,17 @@</span><br><span>        case SKU_0_VAYNE:</span><br><span>    case SKU_1_VAYNE:</span><br><span>    case SKU_2_VAYNE:</span><br><span style="color: hsl(0, 100%, 40%);">-       case SKU_0_PANTHEON:</span><br><span style="color: hsl(0, 100%, 40%);">-    case SKU_1_PANTHEON:</span><br><span style="color: hsl(0, 100%, 40%);">-    case SKU_2_PANTHEON:</span><br><span>         case SKU_0_SONA:</span><br><span>     case SKU_1_SONA:</span><br><span>             *num = ARRAY_SIZE(no_dmic1_sku_gpio_table);</span><br><span>          board_gpio_tables = no_dmic1_sku_gpio_table;</span><br><span>                 break;</span><br><span style="color: hsl(120, 100%, 40%);">+        case SKU_0_PANTHEON:</span><br><span style="color: hsl(120, 100%, 40%);">+  case SKU_1_PANTHEON:</span><br><span style="color: hsl(120, 100%, 40%);">+  case SKU_2_PANTHEON:</span><br><span style="color: hsl(120, 100%, 40%);">+          *num = ARRAY_SIZE(pantheon_gpio_table);</span><br><span style="color: hsl(120, 100%, 40%);">+               board_gpio_tables = pantheon_gpio_table;</span><br><span style="color: hsl(120, 100%, 40%);">+              break;</span><br><span>       default:</span><br><span>             *num = ARRAY_SIZE(nami_default_sku_gpio_table);</span><br><span>              board_gpio_tables = nami_default_sku_gpio_table;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27177">change 27177</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27177"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Idb2dab93178af1dae54265e49522b473b69a35af </div>
<div style="display:none"> Gerrit-Change-Number: 27177 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Crystal Lin <crystal_lin@compal.corp-partner.google.com> </div>