[coreboot-gerrit] Change in coreboot[master]: mainboard/google/nocturne: Set camera power sequence

[Tomasz Figa (Code Review)]

Tomasz Figa has posted comments on this change. ( https://review.coreboot.org/27094 )

Change subject: mainboard/google/nocturne: Set camera power sequence
......................................................................


Patch Set 5:

(2 comments)

https://review.coreboot.org/#/c/27094/5/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl
File src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl:

https://review.coreboot.org/#/c/27094/5/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl@37
PS5, Line 37: 		Method (PMON, 0, Serialized) {
            : 			CTXS(FCAM_RST_L)
            : 			STXS(FCAM_PWR_EN)
            : 			STXS(PCH_FCAM_CLK_EN)
            : 			Sleep(3)
            : 			STXS(FCAM_RST_L)
            : 		}
            : 
            : 		Method (PMOF, 0, Serialized) {
            : 			CTXS(PCH_FCAM_CLK_EN)
            : 			CTXS(FCAM_RST_L)
            : 			CTXS(FCAM_PWR_EN)
            : 		}
Since these are used by both sensor and NVM, doesn't this need to be reference counted? Same for front camera.


https://review.coreboot.org/#/c/27094/5/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl@63
PS5, Line 63: 				Return (0x0F)
Shouldn't this return some actual status? Same for front camera.



-- 
To view, visit https://review.coreboot.org/27094
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4833c0e303174b297c1d193495e08e55d294a717
Gerrit-Change-Number: 27094
Gerrit-PatchSet: 5
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Rajmohan Mani <rajmohan.mani at intel.com>
Gerrit-CC: Tomasz Figa <tfiga at google.com>
Gerrit-Comment-Date: Thu, 21 Jun 2018 03:21:41 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180621/f0595b39/attachment.html>