<p><a href="https://review.coreboot.org/27094">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27094/5/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl">File src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27094/5/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl@37">Patch Set #5, Line 37:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">              Method (PMON, 0, Serialized) {<br>                        CTXS(FCAM_RST_L)<br>                      STXS(FCAM_PWR_EN)<br>                     STXS(PCH_FCAM_CLK_EN)<br>                 Sleep(3)<br>                      STXS(FCAM_RST_L)<br>              }<br><br>           Method (PMOF, 0, Serialized) {<br>                        CTXS(PCH_FCAM_CLK_EN)<br>                 CTXS(FCAM_RST_L)<br>                      CTXS(FCAM_PWR_EN)<br>             }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Since these are used by both sensor and NVM, doesn't this need to be reference counted? Same for front camera.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27094/5/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl@63">Patch Set #5, Line 63:</a> <code style="font-family:monospace,monospace">                          Return (0x0F)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Shouldn't this return some actual status? Same for front camera.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27094">change 27094</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27094"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I4833c0e303174b297c1d193495e08e55d294a717 </div>
<div style="display:none"> Gerrit-Change-Number: 27094 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Rajmohan Mani <rajmohan.mani@intel.com> </div>
<div style="display:none"> Gerrit-CC: Tomasz Figa <tfiga@google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 21 Jun 2018 03:21:41 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>