[coreboot-gerrit] Change in coreboot[master]: drivers/i2c: Add a driver for Semtech SX9310

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27173 )

Change subject: drivers/i2c: Add a driver for Semtech SX9310
......................................................................


Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/chip.h
File src/drivers/i2c/sx9310/chip.h:

https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/chip.h@19
PS1, Line 19: #include <drivers/i2c/generic/chip.h>
Why is this included here?


https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/chip.h@21
PS1, Line 21: #define I2C_SX9310_ACPI_ID	"SX9310"
            : #define I2C_SX9310_ACPI_NAME	"Semtech SX9310"
Can these be moved to sx9310.c?


https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/registers.h
File src/drivers/i2c/sx9310/registers.h:

https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/registers.h@17
PS1, Line 17: REGISTER(TYPE, NAME)
REGISTER(NAME)


https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/sx9310.c
File src/drivers/i2c/sx9310/sx9310.c:

https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/sx9310.c@72
PS1, Line 72: {0}
Not required.



-- 
To view, visit https://review.coreboot.org/27173
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8c434eec9fe2da731e142442503a12e88db2236
Gerrit-Change-Number: 27173
Gerrit-PatchSet: 1
Gerrit-Owner: Enrico Granata <egranata at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Gwendal Grignou <gwendal at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 21 Jun 2018 03:11:55 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180621/1e50a672/attachment.html>