<p><a href="https://review.coreboot.org/27173">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/chip.h">File src/drivers/i2c/sx9310/chip.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/chip.h@19">Patch Set #1, Line 19:</a> <code style="font-family:monospace,monospace">#include <drivers/i2c/generic/chip.h></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why is this included here?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/chip.h@21">Patch Set #1, Line 21:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">#define I2C_SX9310_ACPI_ID    "SX9310"<br>#define I2C_SX9310_ACPI_NAME        "Semtech SX9310"<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Can these be moved to sx9310.c?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/registers.h">File src/drivers/i2c/sx9310/registers.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/registers.h@17">Patch Set #1, Line 17:</a> <code style="font-family:monospace,monospace">REGISTER(TYPE, NAME)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">REGISTER(NAME)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/sx9310.c">File src/drivers/i2c/sx9310/sx9310.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27173/1/src/drivers/i2c/sx9310/sx9310.c@72">Patch Set #1, Line 72:</a> <code style="font-family:monospace,monospace">{0}</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Not required.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27173">change 27173</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27173"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id8c434eec9fe2da731e142442503a12e88db2236 </div>
<div style="display:none"> Gerrit-Change-Number: 27173 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Enrico Granata <egranata@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Gwendal Grignou <gwendal@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 21 Jun 2018 03:11:55 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>