[coreboot-gerrit] Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27168 )

Change subject: inteltool: Add PCI IDs for the C220 PCH series
......................................................................


Patch Set 5:

(2 comments)

https://review.coreboot.org/#/c/27168/5/util/inteltool/gpio.c
File util/inteltool/gpio.c:

https://review.coreboot.org/#/c/27168/5/util/inteltool/gpio.c@873
PS5, Line 873: 		size = 29;
Please leave a comment that this is intentionally reusing the 29
first registers of the LP variant. Otherwise ppl might get confused
and try to "fix" it...


https://review.coreboot.org/#/c/27168/5/util/inteltool/inteltool.h
File util/inteltool/inteltool.h:

https://review.coreboot.org/#/c/27168/5/util/inteltool/inteltool.h@201
PS5, Line 201: #define PCI_DEVICE_ID_INTEL_H81		0x8c5c
again, please align



-- 
To view, visit https://review.coreboot.org/27168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35
Gerrit-Change-Number: 27168
Gerrit-PatchSet: 5
Gerrit-Owner: Quan Tran <qeed.quan at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 20 Jun 2018 12:31:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180620/1963b608/attachment.html>