<p><a href="https://review.coreboot.org/27168">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27168/5/util/inteltool/gpio.c">File util/inteltool/gpio.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27168/5/util/inteltool/gpio.c@873">Patch Set #5, Line 873:</a> <code style="font-family:monospace,monospace">                size = 29;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Please leave a comment that this is intentionally reusing the 29<br>first registers of the LP variant. Otherwise ppl might get confused<br>and try to "fix" it...</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27168/5/util/inteltool/inteltool.h">File util/inteltool/inteltool.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27168/5/util/inteltool/inteltool.h@201">Patch Set #5, Line 201:</a> <code style="font-family:monospace,monospace">#define PCI_DEVICE_ID_INTEL_H81          0x8c5c</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">again, please align</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27168">change 27168</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27168"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 </div>
<div style="display:none"> Gerrit-Change-Number: 27168 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Quan Tran <qeed.quan@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 20 Jun 2018 12:31:38 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>