[coreboot-gerrit] Change in coreboot[master]: tianocore: Add more patches

Nico Huber (Code Review) gerrit at coreboot.org
Wed Jun 20 13:09:31 CEST 2018


Nico Huber has posted comments on this change. ( https://review.coreboot.org/27137 )

Change subject: tianocore: Add more patches
......................................................................


Patch Set 1:

(1 comment)

Is there a reason not to move forward to a newer "stable" revision?

https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch
File payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch:

https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch@34
PS1, Line 34: +  while (StringPtr != NULL) {
> DOS line endings
I think this loop condition is supposed to look for a terminating '\0'...



-- 
To view, visit https://review.coreboot.org/27137
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e2efea930b27749b1097607ab143ce2f91e79ec
Gerrit-Change-Number: 27137
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Wed, 20 Jun 2018 11:09:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180620/faff8fe5/attachment.html>


More information about the coreboot-gerrit mailing list