<p style="white-space: pre-wrap; word-wrap: break-word;">Is there a reason not to move forward to a newer "stable" revision?</p><p><a href="https://review.coreboot.org/27137">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch">File payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch@34">Patch Set #1, Line 34:</a> <code style="font-family:monospace,monospace">+  while (StringPtr != NULL) {
</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">DOS line endings</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think this loop condition is supposed to look for a terminating '\0'...</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27137">change 27137</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27137"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I7e2efea930b27749b1097607ab143ce2f91e79ec </div>
<div style="display:none"> Gerrit-Change-Number: 27137 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 20 Jun 2018 11:09:31 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>