[coreboot-gerrit] Change in coreboot[master]: lib: Add FIT payload support

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25019 )

Change subject: lib: Add FIT payload support
......................................................................


Patch Set 35:

(4 comments)

https://review.coreboot.org/#/c/25019/35/src/arch/arm64/fit_payload.c
File src/arch/arm64/fit_payload.c:

https://review.coreboot.org/#/c/25019/35/src/arch/arm64/fit_payload.c@102
PS35, Line 102: 	if (scratch.header.image_size) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/25019/35/src/include/fit.h
File src/include/fit.h:

https://review.coreboot.org/#/c/25019/35/src/include/fit.h@49
PS35, Line 49: 	const char* compat_string;
"foo* bar" should be "foo *bar"


https://review.coreboot.org/#/c/25019/35/src/lib/fit.c
File src/lib/fit.c:

https://review.coreboot.org/#/c/25019/35/src/lib/fit.c@66
PS35, Line 66: 	if ((board_id() != UNDEFINED_STRAPPING_ID)) {
Unnecessary parentheses


https://review.coreboot.org/#/c/25019/35/src/lib/fit.c@284
PS35, Line 284: 	 * Kernel likes its availabe memory areas at least 1MB
'availabe' may be misspelled - perhaps 'available'?



-- 
To view, visit https://review.coreboot.org/25019
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f27b92a5e074966f893399eb401eb97d784850d
Gerrit-Change-Number: 25019
Gerrit-PatchSet: 35
Gerrit-Owner: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: David Hendricks <david.hendricks at gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin at chromium.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-CC: Patrick Rudolph
Gerrit-Comment-Date: Mon, 18 Jun 2018 13:15:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180618/9efd4eae/attachment.html>