<p><a href="https://review.coreboot.org/25019">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25019/35/src/arch/arm64/fit_payload.c">File src/arch/arm64/fit_payload.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25019/35/src/arch/arm64/fit_payload.c@102">Patch Set #35, Line 102:</a> <code style="font-family:monospace,monospace">        if (scratch.header.image_size) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25019/35/src/include/fit.h">File src/include/fit.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25019/35/src/include/fit.h@49">Patch Set #35, Line 49:</a> <code style="font-family:monospace,monospace">     const char* compat_string;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25019/35/src/lib/fit.c">File src/lib/fit.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25019/35/src/lib/fit.c@66">Patch Set #35, Line 66:</a> <code style="font-family:monospace,monospace">   if ((board_id() != UNDEFINED_STRAPPING_ID)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Unnecessary parentheses</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25019/35/src/lib/fit.c@284">Patch Set #35, Line 284:</a> <code style="font-family:monospace,monospace">       * Kernel likes its availabe memory areas at least 1MB</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">'availabe' may be misspelled - perhaps 'available'?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/25019">change 25019</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25019"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I0f27b92a5e074966f893399eb401eb97d784850d </div>
<div style="display:none"> Gerrit-Change-Number: 25019 </div>
<div style="display:none"> Gerrit-PatchSet: 35 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> </div>
<div style="display:none"> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Aaron Durbin <adurbin@chromium.org> </div>
<div style="display:none"> Gerrit-CC: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-CC: Patrick Rudolph </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 18 Jun 2018 13:15:57 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>