[coreboot-gerrit] Change in coreboot[master]: mainboard/google/nocturne: Set camera power sequence

[Rajmohan Mani (Code Review)]

Rajmohan Mani has posted comments on this change. ( https://review.coreboot.org/27094 )

Change subject: mainboard/google/nocturne: Set camera power sequence
......................................................................


Patch Set 3:

(3 comments)

https://review.coreboot.org/#/c/27094/3/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl
File src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl:

https://review.coreboot.org/#/c/27094/3/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl@155
PS3, Line 155: Name (_CRS, ResourceTemplate ()
Since the NVM0 requires the IMX355 sensor module to be powered, we should also be adding the dependencies for the front camera power resources.

Name (_DEP, Package() { ^^I2C5.CAM0 })

Name (_PR0, Package (0x01) { ^^I2C5.CAM0.RCPR })
Name (_PR3, Package (0x01) { ^^I2C5.CAM0.RCPR })


https://review.coreboot.org/#/c/27094/3/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl@167
PS3, Line 167: 1
32

Page size is 32 bytes, per the NVM data sheet.


https://review.coreboot.org/#/c/27094/3/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl
File src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl:

https://review.coreboot.org/#/c/27094/3/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl@136
PS3, Line 136: 1
32

Page size is 32 bytes, per the NVM data sheet.



-- 
To view, visit https://review.coreboot.org/27094
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4833c0e303174b297c1d193495e08e55d294a717
Gerrit-Change-Number: 27094
Gerrit-PatchSet: 3
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Rajmohan Mani <rajmohan.mani at intel.com>
Gerrit-Comment-Date: Fri, 15 Jun 2018 23:18:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180615/4a271956/attachment.html>