<p><a href="https://review.coreboot.org/27094">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27094/3/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl">File src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27094/3/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl@155">Patch Set #3, Line 155:</a> <code style="font-family:monospace,monospace">Name (_CRS, ResourceTemplate ()</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Since the NVM0 requires the IMX355 sensor module to be powered, we should also be adding the dependencies for the front camera power resources.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Name (_DEP, Package() { ^^I2C5.CAM0 })</p><p style="white-space: pre-wrap; word-wrap: break-word;">Name (_PR0, Package (0x01) { ^^I2C5.CAM0.RCPR })<br>Name (_PR3, Package (0x01) { ^^I2C5.CAM0.RCPR })</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27094/3/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl@167">Patch Set #3, Line 167:</a> <code style="font-family:monospace,monospace">1</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">32</p><p style="white-space: pre-wrap; word-wrap: break-word;">Page size is 32 bytes, per the NVM data sheet.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27094/3/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl">File src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27094/3/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl@136">Patch Set #3, Line 136:</a> <code style="font-family:monospace,monospace">1</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">32</p><p style="white-space: pre-wrap; word-wrap: break-word;">Page size is 32 bytes, per the NVM data sheet.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27094">change 27094</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27094"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I4833c0e303174b297c1d193495e08e55d294a717 </div>
<div style="display:none"> Gerrit-Change-Number: 27094 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Rajmohan Mani <rajmohan.mani@intel.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 15 Jun 2018 23:18:54 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>