[coreboot-gerrit] Change in coreboot[master]: [WIP]soc/intel/common: Add common code to report platform information

Thu Jun 14 00:11:11 CEST 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25810 )

Change subject: [WIP]soc/intel/common: Add common code to report platform information
......................................................................

Patch Set 5:

(28 comments)

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/bootblock/report_platform.c
File src/soc/intel/common/basecode/bootblock/report_platform.c:

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/bootblock/report_platform.c@32
PS5, Line 32: __weak const struct cpu_info* soc_get_cpu_id_table(void)
"foo* bar" should be "foo *bar"

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/bootblock/report_platform.c@38
PS5, Line 38: __weak const struct mch_info* soc_get_mch_id_table(void)
"foo* bar" should be "foo *bar"

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/bootblock/report_platform.c@44
PS5, Line 44: __weak const struct pch_info* soc_get_pch_id_table(void)
"foo* bar" should be "foo *bar"

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/bootblock/report_platform.c@50
PS5, Line 50: __weak const struct igd_info* soc_get_igd_id_table(void)
"foo* bar" should be "foo *bar"

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h
File src/soc/intel/common/basecode/include/intelbasecode/report_platform.h:

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@19
PS5, Line 19: struct cpu_info{
missing space after struct definition

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@20
PS5, Line 20:         u32 cpuid;
code indent should use tabs where possible

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@20
PS5, Line 20:         u32 cpuid;
please, no spaces at the start of a line

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@21
PS5, Line 21:         const char *name;
code indent should use tabs where possible

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@21
PS5, Line 21:         const char *name;
please, no spaces at the start of a line

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@24
PS5, Line 24: struct mch_info{
missing space after struct definition

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@25
PS5, Line 25:         u16 mchid;
code indent should use tabs where possible

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@25
PS5, Line 25:         u16 mchid;
please, no spaces at the start of a line

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@26
PS5, Line 26:         const char *name;
code indent should use tabs where possible

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@26
PS5, Line 26:         const char *name;
please, no spaces at the start of a line

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@29
PS5, Line 29: struct pch_info{
missing space after struct definition

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@30
PS5, Line 30:         u16 lpcid;
code indent should use tabs where possible

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@30
PS5, Line 30:         u16 lpcid;
please, no spaces at the start of a line

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@31
PS5, Line 31:         const char *name;
code indent should use tabs where possible

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@31
PS5, Line 31:         const char *name;
please, no spaces at the start of a line

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@34
PS5, Line 34: struct igd_info{
missing space after struct definition

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@35
PS5, Line 35:         u16 igdid;
code indent should use tabs where possible

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@35
PS5, Line 35:         u16 igdid;
please, no spaces at the start of a line

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@36
PS5, Line 36:         const char *name;
code indent should use tabs where possible

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@36
PS5, Line 36:         const char *name;
please, no spaces at the start of a line

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@40
PS5, Line 40: const struct cpu_info* soc_get_cpu_id_table(void);
"foo* bar" should be "foo *bar"

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@43
PS5, Line 43: const struct mch_info* soc_get_mch_id_table(void);
"foo* bar" should be "foo *bar"

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@46
PS5, Line 46: const struct pch_info* soc_get_pch_id_table(void);
"foo* bar" should be "foo *bar"

https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@49
PS5, Line 49: const struct igd_info* soc_get_igd_id_table(void);
"foo* bar" should be "foo *bar"

-- 
To view, visit https://review.coreboot.org/25810
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1497b72f784db00a334544f6c5ddc2774049107
Gerrit-Change-Number: 25810
Gerrit-PatchSet: 5
Gerrit-Owner: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 13 Jun 2018 22:11:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180613/36148586/attachment.html>