<p><a href="https://review.coreboot.org/25810">View Change</a></p><p>28 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/bootblock/report_platform.c">File src/soc/intel/common/basecode/bootblock/report_platform.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/bootblock/report_platform.c@32">Patch Set #5, Line 32:</a> <code style="font-family:monospace,monospace">__weak const struct cpu_info* soc_get_cpu_id_table(void)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/bootblock/report_platform.c@38">Patch Set #5, Line 38:</a> <code style="font-family:monospace,monospace">__weak const struct mch_info* soc_get_mch_id_table(void)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/bootblock/report_platform.c@44">Patch Set #5, Line 44:</a> <code style="font-family:monospace,monospace">__weak const struct pch_info* soc_get_pch_id_table(void)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/bootblock/report_platform.c@50">Patch Set #5, Line 50:</a> <code style="font-family:monospace,monospace">__weak const struct igd_info* soc_get_igd_id_table(void)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h">File src/soc/intel/common/basecode/include/intelbasecode/report_platform.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@19">Patch Set #5, Line 19:</a> <code style="font-family:monospace,monospace">struct cpu_info{</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">missing space after struct definition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@20">Patch Set #5, Line 20:</a> <code style="font-family:monospace,monospace"> u32 cpuid;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@20">Patch Set #5, Line 20:</a> <code style="font-family:monospace,monospace"> u32 cpuid;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@21">Patch Set #5, Line 21:</a> <code style="font-family:monospace,monospace"> const char *name;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@21">Patch Set #5, Line 21:</a> <code style="font-family:monospace,monospace"> const char *name;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@24">Patch Set #5, Line 24:</a> <code style="font-family:monospace,monospace">struct mch_info{</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">missing space after struct definition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@25">Patch Set #5, Line 25:</a> <code style="font-family:monospace,monospace"> u16 mchid;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@25">Patch Set #5, Line 25:</a> <code style="font-family:monospace,monospace"> u16 mchid;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@26">Patch Set #5, Line 26:</a> <code style="font-family:monospace,monospace"> const char *name;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@26">Patch Set #5, Line 26:</a> <code style="font-family:monospace,monospace"> const char *name;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@29">Patch Set #5, Line 29:</a> <code style="font-family:monospace,monospace">struct pch_info{</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">missing space after struct definition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@30">Patch Set #5, Line 30:</a> <code style="font-family:monospace,monospace"> u16 lpcid;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@30">Patch Set #5, Line 30:</a> <code style="font-family:monospace,monospace"> u16 lpcid;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@31">Patch Set #5, Line 31:</a> <code style="font-family:monospace,monospace"> const char *name;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@31">Patch Set #5, Line 31:</a> <code style="font-family:monospace,monospace"> const char *name;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@34">Patch Set #5, Line 34:</a> <code style="font-family:monospace,monospace">struct igd_info{</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">missing space after struct definition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@35">Patch Set #5, Line 35:</a> <code style="font-family:monospace,monospace"> u16 igdid;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@35">Patch Set #5, Line 35:</a> <code style="font-family:monospace,monospace"> u16 igdid;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@36">Patch Set #5, Line 36:</a> <code style="font-family:monospace,monospace"> const char *name;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@36">Patch Set #5, Line 36:</a> <code style="font-family:monospace,monospace"> const char *name;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@40">Patch Set #5, Line 40:</a> <code style="font-family:monospace,monospace">const struct cpu_info* soc_get_cpu_id_table(void);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@43">Patch Set #5, Line 43:</a> <code style="font-family:monospace,monospace">const struct mch_info* soc_get_mch_id_table(void);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@46">Patch Set #5, Line 46:</a> <code style="font-family:monospace,monospace">const struct pch_info* soc_get_pch_id_table(void);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/5/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@49">Patch Set #5, Line 49:</a> <code style="font-family:monospace,monospace">const struct igd_info* soc_get_igd_id_table(void);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/25810">change 25810</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25810"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id1497b72f784db00a334544f6c5ddc2774049107 </div>
<div style="display:none"> Gerrit-Change-Number: 25810 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Bora Guvendik <bora.guvendik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Hannah Williams <hannah.williams@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: Shaunak Saha <shaunak.saha@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 13 Jun 2018 22:11:11 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>