[coreboot-gerrit] Change in libgfxinit[master]: gma: Give constants depending on Config.CPU* a type

[Nico Huber (Code Review)]

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/27063


Change subject: gma: Give constants depending on Config.CPU* a type
......................................................................

gma: Give constants depending on Config.CPU* a type

To reduce elaboration time dependencies, turn number constants into
variable constants by giving them a type. This will allow us to use
the same code for configurations with constant and non-constant
`GMA.Config.CPU*`.

Change-Id: I0b671cb18701d0ecae118e023e0fd21be5095da0
Signed-off-by: Nico Huber <nico.h at gmx.de>
---
M common/hw-gfx-gma.adb
M common/ironlake/hw-gfx-gma-connectors-fdi.adb
2 files changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/63/27063/1

diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb
index 17dbeae..c1eaa51 100644
--- a/common/hw-gfx-gma.adb
+++ b/common/hw-gfx-gma.adb
@@ -679,7 +679,7 @@
    with
       Pre => Is_Initialized
    is
-      GGC_Reg : constant :=
+      GGC_Reg : constant PCI.Index :=
         (if Config.Gen_G45 or Config.CPU_Ironlake then 16#52# else 16#50#);
       GGC : Word16;
    begin
diff --git a/common/ironlake/hw-gfx-gma-connectors-fdi.adb b/common/ironlake/hw-gfx-gma-connectors-fdi.adb
index 6fd7a1c..9df7fcb 100644
--- a/common/ironlake/hw-gfx-gma-connectors-fdi.adb
+++ b/common/ironlake/hw-gfx-gma-connectors-fdi.adb
@@ -268,7 +268,7 @@
 
    procedure Pre_On (Port_Cfg : Port_Config)
    is
-      Composite_Sel : constant :=
+      Composite_Sel : constant Word32 :=
         (if Config.Has_FDI_Composite_Sel then
             FDI_TX_CTL_COMPOSITE_SYNC_SELECT else 0);
    begin

-- 
To view, visit https://review.coreboot.org/27063
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b671cb18701d0ecae118e023e0fd21be5095da0
Gerrit-Change-Number: 27063
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180612/86fca87a/attachment-0001.html>