<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27063">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gma: Give constants depending on Config.CPU* a type<br><br>To reduce elaboration time dependencies, turn number constants into<br>variable constants by giving them a type. This will allow us to use<br>the same code for configurations with constant and non-constant<br>`GMA.Config.CPU*`.<br><br>Change-Id: I0b671cb18701d0ecae118e023e0fd21be5095da0<br>Signed-off-by: Nico Huber <nico.h@gmx.de><br>---<br>M common/hw-gfx-gma.adb<br>M common/ironlake/hw-gfx-gma-connectors-fdi.adb<br>2 files changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/63/27063/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb</span><br><span>index 17dbeae..c1eaa51 100644</span><br><span>--- a/common/hw-gfx-gma.adb</span><br><span>+++ b/common/hw-gfx-gma.adb</span><br><span>@@ -679,7 +679,7 @@</span><br><span>    with</span><br><span>       Pre => Is_Initialized</span><br><span>    is</span><br><span style="color: hsl(0, 100%, 40%);">-      GGC_Reg : constant :=</span><br><span style="color: hsl(120, 100%, 40%);">+      GGC_Reg : constant PCI.Index :=</span><br><span>         (if Config.Gen_G45 or Config.CPU_Ironlake then 16#52# else 16#50#);</span><br><span>       GGC : Word16;</span><br><span>    begin</span><br><span>diff --git a/common/ironlake/hw-gfx-gma-connectors-fdi.adb b/common/ironlake/hw-gfx-gma-connectors-fdi.adb</span><br><span>index 6fd7a1c..9df7fcb 100644</span><br><span>--- a/common/ironlake/hw-gfx-gma-connectors-fdi.adb</span><br><span>+++ b/common/ironlake/hw-gfx-gma-connectors-fdi.adb</span><br><span>@@ -268,7 +268,7 @@</span><br><span> </span><br><span>    procedure Pre_On (Port_Cfg : Port_Config)</span><br><span>    is</span><br><span style="color: hsl(0, 100%, 40%);">-      Composite_Sel : constant :=</span><br><span style="color: hsl(120, 100%, 40%);">+      Composite_Sel : constant Word32 :=</span><br><span>         (if Config.Has_FDI_Composite_Sel then</span><br><span>             FDI_TX_CTL_COMPOSITE_SYNC_SELECT else 0);</span><br><span>    begin</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27063">change 27063</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27063"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libgfxinit </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I0b671cb18701d0ecae118e023e0fd21be5095da0 </div>
<div style="display:none"> Gerrit-Change-Number: 27063 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>