[coreboot-gerrit] Change in coreboot[master]: util/cbmem: Add cbmem TCPA log support

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/26244 )

Change subject: util/cbmem: Add cbmem TCPA log support
......................................................................


Patch Set 7:

(3 comments)

https://review.coreboot.org/#/c/26244/7/src/commonlib/include/commonlib/coreboot_tables.h
File src/commonlib/include/commonlib/coreboot_tables.h:

https://review.coreboot.org/#/c/26244/7/src/commonlib/include/commonlib/coreboot_tables.h@313
PS7, Line 313:    
Use tabs here as it is done before and after?


https://review.coreboot.org/#/c/26244/7/util/cbmem/cbmem.c
File util/cbmem/cbmem.c:

https://review.coreboot.org/#/c/26244/7/util/cbmem/cbmem.c@704
PS7, Line 704: die("Unable to map tcpa log header\n");
Shall we really die here? Can't you just return with an error and leave the system alive?


https://review.coreboot.org/#/c/26244/7/util/cbmem/cbmem.c@712
PS7, Line 712: die("Unable to map full tcpa log table\n");
Here, too.



-- 
To view, visit https://review.coreboot.org/26244
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2253d86cfc675d45b0a728794cc784215401f4a
Gerrit-Change-Number: 26244
Gerrit-PatchSet: 7
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Comment-Date: Mon, 11 Jun 2018 05:24:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180611/4ec37fd2/attachment.html>