<p><a href="https://review.coreboot.org/26244">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26244/7/src/commonlib/include/commonlib/coreboot_tables.h">File src/commonlib/include/commonlib/coreboot_tables.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26244/7/src/commonlib/include/commonlib/coreboot_tables.h@313">Patch Set #7, Line 313:</a> <code style="font-family:monospace,monospace">   </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Use tabs here as it is done before and after?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26244/7/util/cbmem/cbmem.c">File util/cbmem/cbmem.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26244/7/util/cbmem/cbmem.c@704">Patch Set #7, Line 704:</a> <code style="font-family:monospace,monospace">die("Unable to map tcpa log header\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Shall we really die here? Can't you just return with an error and leave the system alive?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26244/7/util/cbmem/cbmem.c@712">Patch Set #7, Line 712:</a> <code style="font-family:monospace,monospace">die("Unable to map full tcpa log table\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Here, too.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/26244">change 26244</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26244"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ie2253d86cfc675d45b0a728794cc784215401f4a </div>
<div style="display:none"> Gerrit-Change-Number: 26244 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Werner Zeh <werner.zeh@siemens.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 11 Jun 2018 05:24:10 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>