[coreboot-gerrit] Change in coreboot[master]: [WIP]soc/intel/common: Add common code to report platform information
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Sat Jun 9 02:39:07 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25810 )
Change subject: [WIP]soc/intel/common: Add common code to report platform information
......................................................................
Patch Set 4:
(42 comments)
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c
File src/soc/intel/common/basecode/bootblock/report_platform.c:
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@31
PS4, Line 31: __attribute__((weak)) const struct cpu_info* soc_get_cpu_id_table(void)
"foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@37
PS4, Line 37: __attribute__((weak)) const struct mch_info* soc_get_mch_id_table(void)
"foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@43
PS4, Line 43: __attribute__((weak)) const struct pch_info* soc_get_pch_id_table(void)
"foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@49
PS4, Line 49: __attribute__((weak)) const struct igd_info* soc_get_igd_id_table(void)
"foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@65
PS4, Line 65: static void report_cpu_info(const struct cpu_info* cpu_info_table)
"foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@81
PS4, Line 81: int j=0;
spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@90
PS4, Line 90: p[12]=0;
spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@104
PS4, Line 104: while (cpu_info_table[t].name != NULL ) {
space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@124
PS4, Line 124: static void report_mch_info(const struct mch_info* mch_info_table)
"foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@132
PS4, Line 132: while (mch_info_table[i].name != NULL ) {
space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@144
PS4, Line 144: static void report_pch_info(const struct pch_info* pch_info_table)
"foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@151
PS4, Line 151: while (pch_info_table[i].name != NULL ) {
space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@162
PS4, Line 162: static void report_igd_info(const struct igd_info* igd_info_table)
"foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@169
PS4, Line 169: while (igd_info_table[i].name != NULL ) {
space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@182
PS4, Line 182: const struct cpu_info* cpu_info_table = soc_get_cpu_id_table();
"foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@183
PS4, Line 183: const struct mch_info* mch_info_table = soc_get_mch_id_table();
"foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@184
PS4, Line 184: const struct pch_info* pch_info_table = soc_get_pch_id_table();
"foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@185
PS4, Line 185: const struct igd_info* igd_info_table = soc_get_igd_id_table();
"foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h
File src/soc/intel/common/basecode/include/intelbasecode/report_platform.h:
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@19
PS4, Line 19: struct cpu_info{
missing space after struct definition
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@20
PS4, Line 20: u32 cpuid;
code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@20
PS4, Line 20: u32 cpuid;
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@21
PS4, Line 21: const char *name;
code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@21
PS4, Line 21: const char *name;
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@24
PS4, Line 24: struct mch_info{
missing space after struct definition
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@25
PS4, Line 25: u16 mchid;
code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@25
PS4, Line 25: u16 mchid;
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@26
PS4, Line 26: const char *name;
code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@26
PS4, Line 26: const char *name;
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@29
PS4, Line 29: struct pch_info{
missing space after struct definition
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@30
PS4, Line 30: u16 lpcid;
code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@30
PS4, Line 30: u16 lpcid;
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@31
PS4, Line 31: const char *name;
code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@31
PS4, Line 31: const char *name;
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@34
PS4, Line 34: struct igd_info{
missing space after struct definition
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@35
PS4, Line 35: u16 igdid;
code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@35
PS4, Line 35: u16 igdid;
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@36
PS4, Line 36: const char *name;
code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@36
PS4, Line 36: const char *name;
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@40
PS4, Line 40: const struct cpu_info* soc_get_cpu_id_table(void);
"foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@43
PS4, Line 43: const struct mch_info* soc_get_mch_id_table(void);
"foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@46
PS4, Line 46: const struct pch_info* soc_get_pch_id_table(void);
"foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@49
PS4, Line 49: const struct igd_info* soc_get_igd_id_table(void);
"foo* bar" should be "foo *bar"
--
To view, visit https://review.coreboot.org/25810
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1497b72f784db00a334544f6c5ddc2774049107
Gerrit-Change-Number: 25810
Gerrit-PatchSet: 4
Gerrit-Owner: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 09 Jun 2018 00:39:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180609/a491ca5d/attachment.html>
More information about the coreboot-gerrit
mailing list