<p><a href="https://review.coreboot.org/25810">View Change</a></p><p>42 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c">File src/soc/intel/common/basecode/bootblock/report_platform.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@31">Patch Set #4, Line 31:</a> <code style="font-family:monospace,monospace">__attribute__((weak)) const struct cpu_info* soc_get_cpu_id_table(void)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@37">Patch Set #4, Line 37:</a> <code style="font-family:monospace,monospace">__attribute__((weak)) const struct mch_info* soc_get_mch_id_table(void)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@43">Patch Set #4, Line 43:</a> <code style="font-family:monospace,monospace">__attribute__((weak)) const struct pch_info* soc_get_pch_id_table(void)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@49">Patch Set #4, Line 49:</a> <code style="font-family:monospace,monospace">__attribute__((weak)) const struct igd_info* soc_get_igd_id_table(void)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@65">Patch Set #4, Line 65:</a> <code style="font-family:monospace,monospace">static void report_cpu_info(const struct cpu_info* cpu_info_table)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@81">Patch Set #4, Line 81:</a> <code style="font-family:monospace,monospace"> int j=0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces required around that '=' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@90">Patch Set #4, Line 90:</a> <code style="font-family:monospace,monospace"> p[12]=0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces required around that '=' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@104">Patch Set #4, Line 104:</a> <code style="font-family:monospace,monospace"> while (cpu_info_table[t].name != NULL ) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that close parenthesis ')'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@124">Patch Set #4, Line 124:</a> <code style="font-family:monospace,monospace">static void report_mch_info(const struct mch_info* mch_info_table)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@132">Patch Set #4, Line 132:</a> <code style="font-family:monospace,monospace"> while (mch_info_table[i].name != NULL ) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that close parenthesis ')'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@144">Patch Set #4, Line 144:</a> <code style="font-family:monospace,monospace">static void report_pch_info(const struct pch_info* pch_info_table)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@151">Patch Set #4, Line 151:</a> <code style="font-family:monospace,monospace"> while (pch_info_table[i].name != NULL ) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that close parenthesis ')'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@162">Patch Set #4, Line 162:</a> <code style="font-family:monospace,monospace">static void report_igd_info(const struct igd_info* igd_info_table)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@169">Patch Set #4, Line 169:</a> <code style="font-family:monospace,monospace"> while (igd_info_table[i].name != NULL ) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that close parenthesis ')'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@182">Patch Set #4, Line 182:</a> <code style="font-family:monospace,monospace"> const struct cpu_info* cpu_info_table = soc_get_cpu_id_table();</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@183">Patch Set #4, Line 183:</a> <code style="font-family:monospace,monospace"> const struct mch_info* mch_info_table = soc_get_mch_id_table();</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@184">Patch Set #4, Line 184:</a> <code style="font-family:monospace,monospace"> const struct pch_info* pch_info_table = soc_get_pch_id_table();</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootblock/report_platform.c@185">Patch Set #4, Line 185:</a> <code style="font-family:monospace,monospace"> const struct igd_info* igd_info_table = soc_get_igd_id_table();</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h">File src/soc/intel/common/basecode/include/intelbasecode/report_platform.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@19">Patch Set #4, Line 19:</a> <code style="font-family:monospace,monospace">struct cpu_info{</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">missing space after struct definition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@20">Patch Set #4, Line 20:</a> <code style="font-family:monospace,monospace"> u32 cpuid;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@20">Patch Set #4, Line 20:</a> <code style="font-family:monospace,monospace"> u32 cpuid;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@21">Patch Set #4, Line 21:</a> <code style="font-family:monospace,monospace"> const char *name;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@21">Patch Set #4, Line 21:</a> <code style="font-family:monospace,monospace"> const char *name;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@24">Patch Set #4, Line 24:</a> <code style="font-family:monospace,monospace">struct mch_info{</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">missing space after struct definition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@25">Patch Set #4, Line 25:</a> <code style="font-family:monospace,monospace"> u16 mchid;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@25">Patch Set #4, Line 25:</a> <code style="font-family:monospace,monospace"> u16 mchid;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@26">Patch Set #4, Line 26:</a> <code style="font-family:monospace,monospace"> const char *name;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@26">Patch Set #4, Line 26:</a> <code style="font-family:monospace,monospace"> const char *name;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@29">Patch Set #4, Line 29:</a> <code style="font-family:monospace,monospace">struct pch_info{</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">missing space after struct definition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@30">Patch Set #4, Line 30:</a> <code style="font-family:monospace,monospace"> u16 lpcid;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@30">Patch Set #4, Line 30:</a> <code style="font-family:monospace,monospace"> u16 lpcid;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@31">Patch Set #4, Line 31:</a> <code style="font-family:monospace,monospace"> const char *name;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@31">Patch Set #4, Line 31:</a> <code style="font-family:monospace,monospace"> const char *name;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@34">Patch Set #4, Line 34:</a> <code style="font-family:monospace,monospace">struct igd_info{</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">missing space after struct definition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@35">Patch Set #4, Line 35:</a> <code style="font-family:monospace,monospace"> u16 igdid;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@35">Patch Set #4, Line 35:</a> <code style="font-family:monospace,monospace"> u16 igdid;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@36">Patch Set #4, Line 36:</a> <code style="font-family:monospace,monospace"> const char *name;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@36">Patch Set #4, Line 36:</a> <code style="font-family:monospace,monospace"> const char *name;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@40">Patch Set #4, Line 40:</a> <code style="font-family:monospace,monospace">const struct cpu_info* soc_get_cpu_id_table(void);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@43">Patch Set #4, Line 43:</a> <code style="font-family:monospace,monospace">const struct mch_info* soc_get_mch_id_table(void);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@46">Patch Set #4, Line 46:</a> <code style="font-family:monospace,monospace">const struct pch_info* soc_get_pch_id_table(void);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/include/intelbasecode/report_platform.h@49">Patch Set #4, Line 49:</a> <code style="font-family:monospace,monospace">const struct igd_info* soc_get_igd_id_table(void);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/25810">change 25810</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25810"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id1497b72f784db00a334544f6c5ddc2774049107 </div>
<div style="display:none"> Gerrit-Change-Number: 25810 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Bora Guvendik <bora.guvendik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Hannah Williams <hannah.williams@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: Shaunak Saha <shaunak.saha@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 09 Jun 2018 00:39:07 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>