[coreboot-gerrit] Change in coreboot[master]: sb/intel/lynxpoint: Get rid of device_t

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26974 )

Change subject: sb/intel/lynxpoint: Get rid of device_t
......................................................................


Patch Set 1:

(14 comments)

https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/lpc.c
File src/southbridge/intel/lynxpoint/lpc.c:

https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/lpc.c@660
PS1, Line 660: static void pch_lpc_add_io_resource(struct device *dev, u16 base, u16 size, int index)
line over 80 characters


https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/lpc.c@673
PS1, Line 673: static void pch_lpc_add_gen_io_resources(struct device *dev, int reg_value, int index)
line over 80 characters


https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/lpc.c@739
PS1, Line 739: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/lpc.c@739
PS1, Line 739: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/pci.c
File src/southbridge/intel/lynxpoint/pci.c:

https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/pci.c@107
PS1, Line 107: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/pci.c@107
PS1, Line 107: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/pcie.c
File src/southbridge/intel/lynxpoint/pcie.c:

https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/pcie.c@718
PS1, Line 718: static void pcie_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
line over 80 characters


https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/pcie.c@718
PS1, Line 718: static void pcie_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/pcie.c@718
PS1, Line 718: static void pcie_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/sata.c
File src/southbridge/intel/lynxpoint/sata.c:

https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/sata.c@304
PS1, Line 304: static void sata_enable(struct *dev)
need consistent spacing around '*' (ctx:WxV)


https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/sata.c@325
PS1, Line 325: static void sata_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
line over 80 characters


https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/sata.c@325
PS1, Line 325: static void sata_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/sata.c@325
PS1, Line 325: static void sata_set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/watchdog.c
File src/southbridge/intel/lynxpoint/watchdog.c:

https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/watchdog.c@31
PS1, Line 31: 	struct *dev;
need consistent spacing around '*' (ctx:WxV)



-- 
To view, visit https://review.coreboot.org/26974
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I064ff5e76dd95c1770cd24139195b2a5fff2d382
Gerrit-Change-Number: 26974
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 08 Jun 2018 15:23:04 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180608/9930496f/attachment.html>