<p><a href="https://review.coreboot.org/26974">View Change</a></p><p>14 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/lpc.c">File src/southbridge/intel/lynxpoint/lpc.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/lpc.c@660">Patch Set #1, Line 660:</a> <code style="font-family:monospace,monospace">static void pch_lpc_add_io_resource(struct device *dev, u16 base, u16 size, int index)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/lpc.c@673">Patch Set #1, Line 673:</a> <code style="font-family:monospace,monospace">static void pch_lpc_add_gen_io_resources(struct device *dev, int reg_value, int index)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/lpc.c@739">Patch Set #1, Line 739:</a> <code style="font-family:monospace,monospace">static void set_subsystem(struct device *dev, unsigned vendor, unsigned device)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/lpc.c@739">Patch Set #1, Line 739:</a> <code style="font-family:monospace,monospace">static void set_subsystem(struct device *dev, unsigned vendor, unsigned device)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/pci.c">File src/southbridge/intel/lynxpoint/pci.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/pci.c@107">Patch Set #1, Line 107:</a> <code style="font-family:monospace,monospace">static void set_subsystem(struct device *dev, unsigned vendor, unsigned device)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/pci.c@107">Patch Set #1, Line 107:</a> <code style="font-family:monospace,monospace">static void set_subsystem(struct device *dev, unsigned vendor, unsigned device)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/pcie.c">File src/southbridge/intel/lynxpoint/pcie.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/pcie.c@718">Patch Set #1, Line 718:</a> <code style="font-family:monospace,monospace">static void pcie_set_subsystem(struct device *dev, unsigned vendor, unsigned device)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/pcie.c@718">Patch Set #1, Line 718:</a> <code style="font-family:monospace,monospace">static void pcie_set_subsystem(struct device *dev, unsigned vendor, unsigned device)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/pcie.c@718">Patch Set #1, Line 718:</a> <code style="font-family:monospace,monospace">static void pcie_set_subsystem(struct device *dev, unsigned vendor, unsigned device)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/sata.c">File src/southbridge/intel/lynxpoint/sata.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/sata.c@304">Patch Set #1, Line 304:</a> <code style="font-family:monospace,monospace">static void sata_enable(struct *dev)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">need consistent spacing around '*' (ctx:WxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/sata.c@325">Patch Set #1, Line 325:</a> <code style="font-family:monospace,monospace">static void sata_set_subsystem(struct device *dev, unsigned vendor, unsigned device)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/sata.c@325">Patch Set #1, Line 325:</a> <code style="font-family:monospace,monospace">static void sata_set_subsystem(struct device *dev, unsigned vendor, unsigned device)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/sata.c@325">Patch Set #1, Line 325:</a> <code style="font-family:monospace,monospace">static void sata_set_subsystem(struct device *dev, unsigned vendor, unsigned device)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/watchdog.c">File src/southbridge/intel/lynxpoint/watchdog.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26974/1/src/southbridge/intel/lynxpoint/watchdog.c@31">Patch Set #1, Line 31:</a> <code style="font-family:monospace,monospace">   struct *dev;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">need consistent spacing around '*' (ctx:WxV)</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/26974">change 26974</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26974"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I064ff5e76dd95c1770cd24139195b2a5fff2d382 </div>
<div style="display:none"> Gerrit-Change-Number: 26974 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 08 Jun 2018 15:23:04 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>