[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Enable low power S0Idle capability

[Naresh Solanki (Code Review)]

Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/26940 )

Change subject: soc/intel/skylake: Enable low power S0Idle capability
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/26940/2//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/26940/2//COMMIT_MSG@11
PS2, Line 11: FSPUPD
Which FSP UPD is being set?


https://review.coreboot.org/#/c/26940/2/src/soc/intel/skylake/acpi.c
File src/soc/intel/skylake/acpi.c:

https://review.coreboot.org/#/c/26940/2/src/soc/intel/skylake/acpi.c@238
PS2, Line 238: dev
Do NULL check before de-referencing pointer:
const struct soc_intel_skylake_config *config = dev ? dev->chip_info : NULL;


https://review.coreboot.org/#/c/26940/2/src/soc/intel/skylake/acpi.c@287
PS2, Line 287: if (config->s0ix_enable)
NULL check of pointer config before it is dereferenced.
if (config && config->s0ix_enable)



-- 
To view, visit https://review.coreboot.org/26940
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b8a86118232a66e7466d5b8116eff6087b51210
Gerrit-Change-Number: 26940
Gerrit-PatchSet: 2
Gerrit-Owner: Rajneesh Bhardwaj <rajneesh.bhardwaj at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Haridhar Kalvala <haridhar.kalvala at intel.com>
Gerrit-Reviewer: Rajat Jain <rajatja at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Comment-Date: Thu, 07 Jun 2018 12:59:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180607/e347b7c2/attachment.html>