<p><a href="https://review.coreboot.org/26940">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26940/2//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26940/2//COMMIT_MSG@11">Patch Set #2, Line 11:</a> <code style="font-family:monospace,monospace">FSPUPD</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Which FSP UPD is being set?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26940/2/src/soc/intel/skylake/acpi.c">File src/soc/intel/skylake/acpi.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26940/2/src/soc/intel/skylake/acpi.c@238">Patch Set #2, Line 238:</a> <code style="font-family:monospace,monospace">dev</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Do NULL check before de-referencing pointer:<br>const struct soc_intel_skylake_config *config = dev ? dev->chip_info : NULL;</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26940/2/src/soc/intel/skylake/acpi.c@287">Patch Set #2, Line 287:</a> <code style="font-family:monospace,monospace">if (config->s0ix_enable)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">NULL check of pointer config before it is dereferenced.<br>if (config && config->s0ix_enable)</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/26940">change 26940</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26940"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I0b8a86118232a66e7466d5b8116eff6087b51210 </div>
<div style="display:none"> Gerrit-Change-Number: 26940 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Haridhar Kalvala <haridhar.kalvala@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rajat Jain <rajatja@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Naresh Solanki <naresh.solanki@intel.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 07 Jun 2018 12:59:17 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>